mount: Check for !VDIR mount points before handling -o emptydir
ClosedPublic
Actions

Authored by markj on Oct 13 2021, 12:50 AM.

Details

Reviewers

kib
imp

Commits

rG03d5820f738d: mount: Check for !VDIR mount points before handling -o emptydir

Summary

To implement -o emptydir, vfs_emptydir() checks that the passed
directory is empty. This should be done after checking whether the
vnode is of type VDIR, though, or vfs_emptydir() may end up calling
VOP_READDIR on a non-directory.

Reported by: syzbot+4006732c69fb0f792b2c@syzkaller.appspotmail.com

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

markj created this revision.Oct 13 2021, 12:50 AM

Herald added a subscriber: imp. · View Herald TranscriptOct 13 2021, 12:50 AM

markj requested review of this revision.Oct 13 2021, 12:50 AM

Harbormaster completed remote builds in B42095: Diff 96773.Oct 13 2021, 12:50 AM

kib accepted this revision.Oct 13 2021, 1:07 AM

This revision is now accepted and ready to land.Oct 13 2021, 1:07 AM

imp accepted this revision.Oct 13 2021, 1:55 AM

Closed by commit rG03d5820f738d: mount: Check for !VDIR mount points before handling -o emptydir (authored by markj). · Explain WhyOct 13 2021, 1:37 PM

This revision was automatically updated to reflect the committed changes.

markj added a commit: rG03d5820f738d: mount: Check for !VDIR mount points before handling -o emptydir.

Revision Contents
Changeset List

Path

Size

sys/

kern/

vfs_mount.c

10 lines

vfs_subr.c

1 line

Diff 96807

View Options

sys/kern/vfs_mount.c