Page MenuHomeFreeBSD

graphics/airsaned: New port, Apple AirScan compatible SANE web frontend
ClosedPublic

Authored by diizzy on Oct 5 2021, 12:31 PM.
Tags
None
Referenced Files
F86245137: D32314.diff
Mon, Jun 17, 1:21 PM
Unknown Object (File)
Tue, May 28, 10:02 AM
Unknown Object (File)
Sun, May 26, 8:42 AM
Unknown Object (File)
Wed, May 22, 3:00 AM
Unknown Object (File)
Wed, May 22, 2:57 AM
Unknown Object (File)
Tue, May 21, 11:22 AM
Unknown Object (File)
Tue, May 21, 4:32 AM
Unknown Object (File)
Mon, May 20, 10:09 PM
Subscribers
None

Details

Summary
Test Plan

Compile tested on FreeBSD 13.0-STABLE #0 stable/13-n246086-a20c597c6d7 (amd64) (make, make check-plist)
Poudriere testport OK 12.2-RELEASE (amd64)
Runtime tested by submitter

Diff Detail

Repository
R11 FreeBSD ports repository
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

diizzy created this revision.
diizzy edited the test plan for this revision. (Show Details)
graphics/airsaned/Makefile
18

^ I would sort USES alphabetically

arrowd requested changes to this revision.Oct 5 2021, 3:06 PM
arrowd added inline comments.
graphics/airsaned/Makefile
5

I was thinking that this is when we should use GH_TAGNAME. However, the example from the Handbook you mentioned in the PR does the same. Hum!

graphics/airsaned/files/patch-CMakeLists.txt
16

I'd rather do this

if(CMAKE_SYSTEM_NAME STREQUAL FreeBSD)
  set(USB_LIBRARY usb-1.0)
else()
  set(USB_LIBRARY usb)
endif()

and the use ${USB_LIBRARY} in the target_link_libraries()call.

37

Ditto, probably? Do we really need to repeat the whole block of install() calls?

Another problem is that it installs into fixed prefix. I think you can just write DESTINATION etc/airsane it will work automagically.

graphics/airsaned/files/patch-server-server.cpp
9

I'm afraid, this should be done at post-patch with REINPLACE_CMD. This way we can substitute the real PREFIX value and not fix it to /usr/local.

This revision now requires changes to proceed.Oct 5 2021, 3:06 PM

Sort USES
Don't hardcode install paths
Use "@sample" for configuration files

Looks great now. Thanks for following the comments!

This revision is now accepted and ready to land.Oct 5 2021, 5:34 PM

Simplify install logic for files in etc directory

This revision now requires review to proceed.Oct 5 2021, 6:11 PM
This revision is now accepted and ready to land.Oct 5 2021, 6:29 PM