Details
Compile tested on FreeBSD 13.0-STABLE #0 stable/13-n246086-a20c597c6d7 (amd64) (make, make check-plist)
Poudriere testport OK 12.2-RELEASE (amd64)
Runtime tested by submitter
Diff Detail
- Repository
- R11 FreeBSD ports repository
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
graphics/airsaned/Makefile | ||
---|---|---|
18 | ^ I would sort USES alphabetically |
graphics/airsaned/Makefile | ||
---|---|---|
5 | I was thinking that this is when we should use GH_TAGNAME. However, the example from the Handbook you mentioned in the PR does the same. Hum! | |
graphics/airsaned/files/patch-CMakeLists.txt | ||
16 | I'd rather do this if(CMAKE_SYSTEM_NAME STREQUAL FreeBSD) set(USB_LIBRARY usb-1.0) else() set(USB_LIBRARY usb) endif() and the use ${USB_LIBRARY} in the target_link_libraries()call. | |
37 | Ditto, probably? Do we really need to repeat the whole block of install() calls? Another problem is that it installs into fixed prefix. I think you can just write DESTINATION etc/airsane it will work automagically. | |
graphics/airsaned/files/patch-server-server.cpp | ||
9 | I'm afraid, this should be done at post-patch with REINPLACE_CMD. This way we can substitute the real PREFIX value and not fix it to /usr/local. |