Page MenuHomeFreeBSD

cam(4): Limit search for disks in SES enclosure by single bus
ClosedPublic

Authored by mav on Oct 5 2021, 2:26 AM.

Details

Summary

At least for SAS we only support now disks are typically connected to the same bus as the enclosure. Limiting the search scope makes it faster on systems with multiple buses and thousands of disks.

Test Plan

Works best in combination with https://reviews.freebsd.org/D32304.

Diff Detail

Repository
R10 FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

mav requested review of this revision.Oct 5 2021, 2:26 AM
mav created this revision.
mav edited the summary of this revision. (Show Details)
sys/cam/scsi/scsi_enc_ses.c
897

This is going in after your change from MATCH_NONE == 0 to MATCH_ANY == 0?
If so, then it's good.

sys/cam/scsi/scsi_enc_ses.c
897

It is. Though not sure why have you mentioned MATCH_ANY == 0 part, not the optimization in the same review.

This revision was not accepted when it landed; it landed in state Needs Review.Oct 5 2021, 7:04 PM
This revision was automatically updated to reflect the committed changes.