ib mad: fix incorrect list entry offsets
AbandonedPublic
Actions

Authored by markj on Jul 29 2015, 1:55 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sun, Oct 5, 8:56 AM

	Unknown Object (File)
	Sun, Oct 5, 7:58 AM

	Unknown Object (File)
	Sun, Oct 5, 6:39 AM

	Unknown Object (File)
	Sun, Oct 5, 5:52 AM

	Unknown Object (File)
	Sun, Oct 5, 5:46 AM

	Unknown Object (File)
	Sun, Oct 5, 5:26 AM

	Unknown Object (File)
	Feb 12 2025, 5:04 AM

	Unknown Object (File)
	May 16 2024, 6:33 PM

View All 22 Files

Subscribers

imp

Details

Reviewers

• hselasky

Summary

struct to_fifo maintains lists of struct tf_entry. But the list entry
offsets in these two structs must be equal for list_for_each_entry() to
work properly: otherwise the terminating condition of the loop is wrong.

Submitted by: Tao Liu <Tao.Liu@isilon.com>

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Event Timeline

markj updated this revision to Diff 7447.Jul 29 2015, 1:55 AM

markj retitled this revision from to ib mad: fix incorrect list entry offsets.

markj edited the test plan for this revision. (Show Details)

markj added a reviewer: • hselasky.

markj updated this object.

Herald added a subscriber: imp. · View Herald TranscriptJul 29 2015, 1:55 AM

markj updated this object.Jul 29 2015, 1:55 AM

Heh, not quite.

There's a bug here, but we misunderstood the Linux list macros when debugging this. The real problem is in tf_dequeue(); I'll put up a new CR shortly. Sorry for the noise.

Revision Contents
Changeset List

Path

Size

sys/

ofed/

drivers/

infiniband/

core/

mad_priv.h

4 lines

Diff 7447

View Options

sys/ofed/drivers/infiniband/core/mad_priv.h

ib mad: fix incorrect list entry offsetsAbandonedPublicActions