Paths

Table of Contentst

Differential D32274

devel/ghub: Update to 3.5.4
ClosedPublic
Actions

Authored by yasu on Oct 2 2021, 7:09 AM.

Tags

None

Referenced Files

	F153279972: D32274.diff
	Mon, Apr 20, 5:28 AM

	Unknown Object (File)
	Sat, Apr 18, 3:38 PM

	Unknown Object (File)
	Fri, Apr 17, 2:07 PM

	Unknown Object (File)
	Thu, Apr 16, 7:46 PM

	Unknown Object (File)
	Tue, Apr 14, 11:45 PM

	Unknown Object (File)
	Fri, Apr 10, 3:20 PM

	Unknown Object (File)
	Tue, Mar 31, 8:40 AM

	Unknown Object (File)
	Mon, Mar 30, 10:24 PM

Subscribers

Details

Reviewers

meta
ygy

Commits

R11:193f2611563f: devel/ghub: Update to 3.5.4

Summary

Don't install ghub-pkg.el as it isn't necessary.

Changes: https://github.com/magit/ghub/commits/v3.5.4
Approved by: meta (mentor), ygy (mentor)

Test Plan

Build succeeds with 13.0-RELEASE amd64.

Diff Detail

Repository

R11 FreeBSD ports repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

yasu created this revision.Oct 2 2021, 7:09 AM

Herald added a subscriber: mat. · View Herald TranscriptOct 2 2021, 7:09 AM

yasu requested review of this revision.Oct 2 2021, 7:09 AM

Harbormaster completed remote builds in B41921: Diff 96133.Oct 2 2021, 7:09 AM

Add 'Differential Revision:' to commit message.

Harbormaster completed remote builds in B41922: Diff 96134.Oct 2 2021, 7:11 AM

ygy added inline comments.Oct 2 2021, 7:27 AM

devel/ghub/Makefile
29	Can you share more info about why we switched from the original method?

yasu added inline comments.Oct 2 2021, 7:39 AM

devel/ghub/Makefile
29	`.el` also matches `forge-pkg.el`. But it is only used to create package for ELPA and unnecessary for FreeBSD port/package. So I changed way to install so `forge-pkg.el` isn't installed.

yasu mentioned this in D32503: devel/forge: Update to 0.3.0.Oct 15 2021, 2:04 AM

This revision was not accepted when it landed; it landed in state Needs Review.Oct 27 2021, 4:17 PM

Closed by commit R11:193f2611563f: devel/ghub: Update to 3.5.4 (authored by yasu). · Explain Why

This revision was automatically updated to reflect the committed changes.

yasu added a commit: R11:193f2611563f: devel/ghub: Update to 3.5.4.

Revision Contents
Changeset List

Path

Size

devel/

ghub/

11 lines

6 lines

1 line

Diff 97567

devel/ghub/Makefile

Loading...

devel/ghub/distinfo

Loading...

devel/ghub/pkg-plist

Loading...