Page MenuHomeFreeBSD

Update the list of developers and contributors about Yasuhiro Kimura.
ClosedPublic

Authored by yasu on Sep 25 2021, 7:19 AM.
Tags
None
Referenced Files
F86786870: D32133.id95707.diff
Tue, Jun 25, 1:39 PM
Unknown Object (File)
Fri, Jun 7, 4:15 AM
Unknown Object (File)
Apr 13 2024, 9:38 PM
Unknown Object (File)
Apr 12 2024, 9:06 PM
Unknown Object (File)
Jan 7 2024, 9:16 AM
Unknown Object (File)
Dec 29 2023, 4:28 PM
Unknown Object (File)
Dec 14 2023, 11:35 PM
Unknown Object (File)
Nov 17 2023, 9:43 PM
Subscribers
None

Details

Summary

It corresponds to the 2nd step of the procedure described in section
7.1 of Committer's Guide.

Approved by: meta(mentor), ygy(mentor)

Diff Detail

Repository
R9 FreeBSD doc repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

yasu requested review of this revision.Sep 25 2021, 7:19 AM
yasu created this revision.

Looks good to me, approved. Two nits on the commit message:

  • There is a space before "(mentor)", e.g. meta (mentor) instead of meta(mentor)
  • Don't forget the "Differential Revision:" entry :)
This revision is now accepted and ready to land.Sep 25 2021, 7:24 AM

Adject commit message.

  • Add 'Differential Revision:'
  • Remove lines added by 'arc diff'.
This revision now requires review to proceed.Sep 25 2021, 7:26 AM
  • The first line of the commit message is not a full sentence, hence you can remove the ending period.
  • Just a reminder that the "Approved by:" etc are tab-separated, e.g. Approved by:(tab) ygy (mentor)
  • Again, there should be a space before "(mentor)", e.g. meta (mentor) instead of meta(mentor).
In D32133#725199, @ygy wrote:

Looks good to me, approved.

Thanks.

Two nits on the commit message:

  • There is a space before "(mentor)", e.g. meta (mentor) instead of meta(mentor)

I'll fix it.

  • Don't forget the "Differential Revision:" entry :)

I have added it :-).

BTW I noticed that commit messages are modified by arc command when I create new review with arc diff.
Is there any way to prevent it?

In D32133#725208, @yasu wrote:

BTW I noticed that commit messages are modified by arc command when I create new review with arc diff.
Is there any way to prevent it?

I am not an expert on arc, and I don't use it at all - maybe @meta can weigh in here. That said, you have my approval to commit (just change it locally, preview and push it without arc) once you addressed the items that I have mentioned:

In D32133#725207, @ygy wrote:
  • The first line of the commit message is not a full sentence, hence you can remove the ending period.
  • Just a reminder that the "Approved by:" etc are tab-separated, e.g. Approved by:(tab) ygy (mentor)
  • Again, there should be a space before "(mentor)", e.g. meta (mentor) instead of meta(mentor).
This revision is now accepted and ready to land.Sep 25 2021, 7:40 AM