It corresponds to the 2nd step of the procedure described in section
7.1 of Committer's Guide.
Approved by: meta(mentor), ygy(mentor)
Differential D32133
Update the list of developers and contributors about Yasuhiro Kimura. yasu on Sep 25 2021, 7:19 AM. Authored by Tags None Referenced Files
Subscribers None
Details It corresponds to the 2nd step of the procedure described in section Approved by: meta(mentor), ygy(mentor)
Diff Detail
Event TimelineComment Actions Looks good to me, approved. Two nits on the commit message:
Comment Actions Adject commit message.
Comment Actions
Comment Actions Thanks.
I'll fix it.
I have added it :-). BTW I noticed that commit messages are modified by arc command when I create new review with arc diff. Comment Actions I am not an expert on arc, and I don't use it at all - maybe @meta can weigh in here. That said, you have my approval to commit (just change it locally, preview and push it without arc) once you addressed the items that I have mentioned: |