Add an author entry for Yasuhiro Kimura (yasu)

[yasu]

Summary

Add an author entry for Yasuhiro Kimura (yasu). It corresponds to the 1st step of the procedure described in section 7.1 of Committer's Guide.

[yasu]

Add an author entry for Yasuhiro Kimura (yasu)

Add an author entry for Yasuhiro Kimura (yasu). It corresponds to the
1st step of the procedure described in section 7.1 of Committer's Guide.

[ygy]

You should also have "Approved by: meta, ygy (mentors)" (or the one that actually approved your review) in your commit message while you are under mentorship. Also, after "Approved by:" it is a tab in the commit message, but it is fine here. Could you update the Summary field to reflect the commit message?

[ygy]

Also, there is no need to repeat the first line of your git commit message again in the "message body".

[meta]

Differential Revision should be full URL.

Differential Revisoin:<tab>https://reviews.freebsd.org/D32080

Use Approved by instead of Reviewed by and include mentors' account if it is actually approved.

BTW, have you installed commit message template?
https://docs.freebsd.org/en/articles/committers-guide/#git-primer

[yasu]

Update commit message of Git commit.

• Remove duplicated sentence.
• Fix 'Differential Revision:'.

[ygy]

You should use "Approved by:" instead of "Reviewed by:". Also my handle is "ygy" instead of "ypg".

[yasu]

In D32080#724392, @meta wrote:

Differential Revision should be full URL.

Differential Revisoin:<tab>https://reviews.freebsd.org/D32080

Should be fixed.

BTW, have you installed commit message template?
https://docs.freebsd.org/en/articles/committers-guide/#git-primer

yasu@rolling-vm-freebsd2[1288]% pwd
/usr/doc
yasu@rolling-vm-freebsd2[1289]% ls -l .git/hooks/prepare-commit-msg
-rwxr-xr-x  1 yasu  wheel  2412  9月 23 15:43 .git/hooks/prepare-commit-msg*
yasu@rolling-vm-freebsd2[1290]%

BTW I have a question. How can I see commit message from web interface?

[ygy]

In D32080#724506, @yasu wrote:

BTW I have a question. How can I see commit message from web interface?

Revision Contents -> Commits -> Show More...

I personally would first write the proposed commit messages in the Summary field of the review and quote them in triple backtick pairs. I have done this for you for this revision.

For me, I don't bother too much with the message of the actual git commit too much. After the review is approved, I then populate/amend the actual commit and push. Hope this helps!

[yasu]

Update commit message of Git commit

• Use 'Approved by:'instead of 'Reviewed by:'.
• Fix handle of Guangyuan.

[yasu]

In D32080#724501, @ygy wrote:

You should use "Approved by:" instead of "Reviewed by:".

Updated.

Also my handle is "ygy" instead of "ypg".

My bad. Fixed.

[yasu]

In D32080#724508, @ygy wrote:

In D32080#724506, @yasu wrote:

BTW I have a question. How can I see commit message from web interface?

Revision Contents -> Commits -> Show More...

I got it. Now I can see it from web interface.

I personally would first write the proposed commit messages in the Summary field of the review and quote them in triple backtick pairs. I have done this for you for this revision.

For me, I don't bother too much with the message of the actual git commit too much. After the review is approved, I then populate/amend the actual commit and push. Hope this helps!

Thank for letting me know.

[ygy]

Approved, please go ahead and push your first commit!

Beware that the "Approved by" line should contain the mentor(s) that actually approved this revision at the time of committing.