Page MenuHomeFreeBSD

hyperv storvsc: Don't abuse struct sglist to hold virtual addresses.
Needs ReviewPublic

Authored by jhb on Mon, Sep 13, 6:09 PM.

Details

Reviewers
emaste
whu
Summary

struct sglist is intended for holding S/G lists of physical address
ranges, not virtual address ranges. GCC 9.x issues several warnings
due to casts between pointers and integers of different sizes as a
result (vm_paddr_t is 64-bits on i386). Instead, add a local 'struct
hv_sglist' which uses an array of 'struct iovec' to hold the S/G list
of virtual address ranges.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 41487
Build 38376: arc lint + arc unit

Event Timeline

jhb requested review of this revision.Mon, Sep 13, 6:09 PM

This looks reasonable to me but I will defer to @whu for detailed review.

Please give me a few days to review. I am tied up with other issues right now. Thanks!