Differential D31912

audio/tagutil: Rework Makefile and adjust hardcoded compiler flags
ClosedPublic
Actions

Authored by diizzy on Sep 11 2021, 8:32 AM.

Details

Reviewers

tcberner
arrowd
lbartoletti

Commits

R11:f98014780023: audio/tagutil: Adjust hardcoded compiler flags
R11:fb6ad88501bf: audio/tagutil: Rework Makefile to follow Porter's Handbook

Summary

Rework Makefile to follow Porter's Handbook
Remove hardcoded generic optimization
Remove compiler flags -o aslr and -fsanitize=undefined to fix build on other platforms than x86
PR: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=258351 (wainting on maintainer or until maintainer timeout)

Test Plan

Compile and lightly runtime tested on FreeBSD 13.0-STABLE #0 stable/13-n246453-06887e06864-dirty (arm64)
Poudriere testport OK 12.2-RELEASE (amd64)
Poudriere testport OK 11.4-RELEASE (amd64)

Reference:
https://portsfallout.com/port/1205/

Diff Detail

Repository

R11 FreeBSD ports repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

diizzy requested review of this revision.Sep 11 2021, 8:32 AM

diizzy created this revision.

PR: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=258351 (wainting on maintainer or until maintainer timeout)

This falls under the "just fix it" blanket.

Can you do it in two commits:

Rework Makefile to follow Porter's Handbook
Remove hardcoded generic optimization & Remove compiler flags -o aslr and -fsanitize=undefined to fix build on other platforms than x86

This revision is now accepted and ready to land.Sep 11 2021, 10:35 AM

Closed by commit R11:fb6ad88501bf: audio/tagutil: Rework Makefile to follow Porter's Handbook (authored by diizzy). · Explain WhySep 12 2021, 8:38 AM

This revision was automatically updated to reflect the committed changes.

diizzy added a commit: R11:fb6ad88501bf: audio/tagutil: Rework Makefile to follow Porter's Handbook.

diizzy added a commit: R11:f98014780023: audio/tagutil: Adjust hardcoded compiler flags.