Page MenuHomeFreeBSD

audio/tagutil: Rework Makefile and adjust hardcoded compiler flags
ClosedPublic

Authored by diizzy on Sat, Sep 11, 8:32 AM.

Details

Summary

Rework Makefile to follow Porter's Handbook
Remove hardcoded generic optimization
Remove compiler flags -o aslr and -fsanitize=undefined to fix build on other platforms than x86
PR: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=258351 (wainting on maintainer or until maintainer timeout)

Test Plan

Compile and lightly runtime tested on FreeBSD 13.0-STABLE #0 stable/13-n246453-06887e06864-dirty (arm64)
Poudriere testport OK 12.2-RELEASE (amd64)
Poudriere testport OK 11.4-RELEASE (amd64)

Reference:
https://portsfallout.com/port/1205/

Diff Detail

Repository
R11 FreeBSD ports repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

diizzy created this revision.
PR: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=258351 (wainting on maintainer or until maintainer timeout)

This falls under the "just fix it" blanket.

Can you do it in two commits:

  1. Rework Makefile to follow Porter's Handbook
  2. Remove hardcoded generic optimization & Remove compiler flags -o aslr and -fsanitize=undefined to fix build on other platforms than x86

?

This revision is now accepted and ready to land.Sat, Sep 11, 10:35 AM