Paths

Table of Contentst

D31858 (PR 258310)
ClosedPublic
Actions

Authored by arichardson on Sep 6 2021, 3:20 PM.

Details

Reviewers

kib
imp

Commits

rGb0188ea20071: Add a test for https://reviews.freebsd.org/D31858 (PR 258310)
rGd7d962ead0b6: Add a test for https://reviews.freebsd.org/D31858 (PR 258310)

Summary

This test (based on https://github.com/jiixyj/epoll-shim/pull/32#issuecomment-891276654)
fails reproducibly on QEMU with KVM and -smp 2 prior to D31858 and passes
with the patch applied.

Test Plan

Passes with D31858 (and fails on smp qemu before)

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

arichardson created this revision.Sep 6 2021, 3:20 PM

Herald added a subscriber: imp. · View Herald TranscriptSep 6 2021, 3:20 PM

arichardson requested review of this revision.Sep 6 2021, 3:20 PM

Harbormaster completed remote builds in B41407: Diff 94738.Sep 6 2021, 3:20 PM

arichardson mentioned this in D31858: kqueue: drain kqueue taskqueue if syscall tickled it.Sep 6 2021, 3:22 PM

imp accepted this revision.Sep 6 2021, 3:34 PM

This revision is now accepted and ready to land.Sep 6 2021, 3:34 PM

kib added inline comments.Sep 6 2021, 10:33 PM

tests/sys/kqueue/kqueue_peek_signal.c
32	This tag is definitely extra.
73	No, as I said, the issue is not with the signal visibility. It is the visibility of the nested kqueue activation.

Correct comment and drop $FreeBSD$ tags

This revision now requires review to proceed.Sep 7 2021, 9:33 AM

Harbormaster completed remote builds in B41416: Diff 94788.Sep 7 2021, 9:33 AM

arichardson marked an inline comment as done.Sep 7 2021, 9:33 AM

kib accepted this revision.Sep 7 2021, 9:54 AM

This revision is now accepted and ready to land.Sep 7 2021, 9:54 AM

Closed by commit rGd7d962ead0b6: Add a test for https://reviews.freebsd.org/D31858 (PR 258310) (authored by arichardson). · Explain WhySep 13 2021, 9:33 AM

This revision was automatically updated to reflect the committed changes.

arichardson added a commit: rGd7d962ead0b6: Add a test for https://reviews.freebsd.org/D31858 (PR 258310).

arichardson added a commit: rGb0188ea20071: Add a test for https://reviews.freebsd.org/D31858 (PR 258310).May 7 2022, 3:57 PM

Revision Contents
Changeset List

Path

Size

tests/

sys/

kqueue/

Makefile

2 lines

kqueue_peek_signal.c

106 lines

Diff 95028

View Options

tests/sys/kqueue/Makefile