Page MenuHomeFreeBSD

net/opensips31: Open Source SIP Server
ClosedPublic

Authored by diizzy on Sep 1 2021, 9:32 AM.

Details

Summary

New port, removed deprecated entries in Makefile and connected it in net/Makefile otherwise it's the same as the submission

Deprecated entries:

# Created by: Euan Thoms <euan@potensol.com>
# $FreeBSD$

PR: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=253844

Test Plan

Compile tested on FreeBSD 13.0-STABLE #0 stable/13-n246086-a20c597c6d7 (amd64) (make, make check-plist) with all options
Poudriere testport OK 12.2-RELEASE (amd64) (default options)
Poudriere testport OK 11.4-RELEASE (amd64) (default options)

Diff Detail

Repository
R11 FreeBSD ports repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

diizzy requested review of this revision.Sep 1 2021, 9:32 AM
diizzy created this revision.

Great job shepherding the original submitter through the process!

net/opensips31/Makefile
1

Why not just opensips?

34

Are these subs really needed? They do not contain varying parts, so their contents can be put directly to pkg-plist.

51

This seems to be a no-op: pkg-message doesn't contain any substitutions.

76

There and below OPT_VARS [1] helpers can be used.

[1]: https://docs.freebsd.org/en/books/porters-handbook/makefiles/#options-vars

Remove PLIST_SUB and hardcode paths in pkg-plist
Remove SUB_FILES for pkg-message (not needed)
Convert if statments for options to OPT_VARS
Use framework variables for cp and mv instead of hardcoding

net/opensips31/Makefile
1

Upstream maintains several LTS branches

34

You're right, fixed

51

Corrected

76

Section reworked

net/opensips31/Makefile
101

These install targets look strange to me. When the option is OFF, these don't get added to TMPPLIST, but they are still present in the STAGEDIR, so poudriere will report them as orphaned.

These directories should be removed from the staging dir when corresponding options are OFF.

Or am I missing something?

118

This should be ${MV}, I think. @sample keyword will copy dictionary.opensips.sample file to dictionary.opensips during installation.

Also, it seems that this file is installed even with RADIUS turned to off.

net/opensips31/Makefile
101

These seem to work as expected, at least testport in Poudriere doesn't complain

net/opensips31/Makefile
101

These seem to work as expected, at least testport in Poudriere doesn't complain

Ah, now I get it. These targets are used only to generate pkg-plist items dynamically. Instead, these files can be put into pkg-plist with %%PGSQL%% prefix.

While I'm not a fan of dynamic plist generation, I won't insist if you leave it as is.

Move all options to static plist
Change INSTALL_DATA to MV

net/opensips31/Makefile
101

Fixed

118

Fixed

Last nitpicks. When all comments are resolved, feel free to push.

Good job handling such complex port.

net/opensips31/Makefile
47

This line is not needed.

net/opensips31/pkg-plist
735

Now that we don't append anything to PKGPLIST manually, this line is not needed.

This revision is now accepted and ready to land.Sep 5 2021, 8:52 AM
net/opensips31/pkg-plist
724

For the sake of documentation, L724 and L725 were fixed prior to committing :-)