Page MenuHomeFreeBSD

Address bug 193698 - Porter's Handbook chapter 10 links to self
ClosedPublic

Authored by jgh on Jul 23 2015, 6:04 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Apr 24, 5:49 PM
Unknown Object (File)
Feb 13 2024, 1:10 AM
Unknown Object (File)
Feb 8 2024, 6:48 AM
Unknown Object (File)
Feb 3 2024, 11:53 AM
Unknown Object (File)
Jan 24 2024, 10:21 PM
Unknown Object (File)
Jan 21 2024, 4:55 PM
Unknown Object (File)
Jan 19 2024, 4:06 PM
Unknown Object (File)
Dec 20 2023, 12:01 AM
Subscribers
None

Diff Detail

Repository
rD FreeBSD doc repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

jgh retitled this revision from to Address bug 193698 - Porter's Handbook chapter 10 links to self.
jgh updated this object.
jgh edited the test plan for this revision. (Show Details)
jgh added reviewers: bcr, wblock, remko.
jgh set the repository for this revision to rD FreeBSD doc repository - subversion.
jgh removed rD FreeBSD doc repository - subversion as the repository for this revision.

fixed igor issue

porters-handbook/upgrading/chapter.xml
275 โ†—(On Diff #7232)

It might be a little clearer if the link description was the entire "problem report submission guidelines" string. Thanks!

jgh set the repository for this revision to rD FreeBSD doc repository - subversion.

address feedback

porters-handbook/upgrading/chapter.xml
5 โ†—(On Diff #7264)

There should be no whitespace between the tag and the content:

...writing.html">problem

Phabricator says there is a change there, but I can't tell what it was. There is still a newline and spaces between the opening <link> tag and the contents.

That is the indent. You asked me to remove the whitespace, and I believe I did. If you could look at the raw diff, perhaps that will clarify what is going on. If not, I will work through this until it is correct.

In D3173#63792, @jgh wrote:

That is the indent. You asked me to remove the whitespace, and I believe I did. If you could look at the raw diff, perhaps that will clarify what is going on. If not, I will work through this until it is correct.

The whitespace being referred to was the newline at the end of the <link> tag (ignore the indent):

Currently:

xlink:href="&url.articles.problem-reports;/pr-writing.html">
problem report submission guidelines</link>.</para>

That newline should not be there, it will render as a space on the leading part of the highlighted link (like _problem). It should be:

xlink:href="&url.articles.problem-reports;/pr-writing.html">problem
report submission guidelines</link>.</para>

With no whitespace (horizontal or vertical) in between ">" and "problem". Likewise with the closing tag: "guidelines</link>".

jgh edited edge metadata.

address feedback

wblock edited edge metadata.

Please remember to build-test before commit. Thanks!

This revision is now accepted and ready to land.Jul 27 2015, 4:45 PM
This revision was automatically updated to reflect the committed changes.