unit tests
ClosedPublic
Actions

Authored by diizzy on Aug 26 2021, 10:31 PM.

Details

Reviewers

tcberner
arrowd
lbartoletti

Commits

R11:3014d5a8f0e3: devel/glib20: Add option for unit tests

Summary

Don't build tests by default, the reduces time spent on compiling substantially (~450 objects vs ~1200)
Add dependency for test suite / unit tests

Test Plan

Compile and tested on FreeBSD 13.0-STABLE #0 stable/13-n246086-a20c597c6d7 (amd64) (make, make check-plist, make test)

Diff Detail

Repository

R11 FreeBSD ports repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

diizzy requested review of this revision.Aug 26 2021, 10:31 PM

diizzy created this revision.

arrowd added inline comments.Aug 27 2021, 8:05 AM

devel/glib20/files/patch-gio_tests_meson.build
8	You are patching out some tests? Why? Are they failing at the moment?

tcberner added inline comments.Aug 27 2021, 2:40 PM

devel/glib20/files/patch-gio_tests_meson.build
8	there is a circular dependency otherwise as they require applications provided by ports using glib themselves.

The only issue (afaik) this that one error in tests that I'm not sure on how to handle, any ideas?

In D31702#719953, @diizzy wrote:

The only issue (afaik) this that one error in tests that I'm not sure on how to handle, any ideas?

Is this issue also present on the glib CI?
Maybe you could open an issue upstream.

In D31702#720251, @lbartoletti wrote:

In D31702#719953, @diizzy wrote:

The only issue (afaik) this that one error in tests that I'm not sure on how to handle, any ideas?

Is this issue also present on the glib CI?
Maybe you could open an issue upstream.

Hi,

I can't seem to find that test in their CI at all and not any obvious commit related so I've opened an issue at upstream.
https://gitlab.gnome.org/GNOME/glib/-/issues/2488