cargo.mk: respect CC when --target is passed
ClosedPublic
Actions

Authored by jbeich on Aug 16 2021, 7:30 PM.

Details

Reviewers

tobik

Group Reviewers

rust

Commits

R11:93924a20b38e: Uses/cargo: respect CC when --target is passed

Summary

Fixes bug 257588 but may benefit other ports. Proposed commit message:

Mk/Uses/cargo.mk: respect CC when --target is passed

devel/cargo-c always passes --target when building consumers.
Some other USES=cargo consumers may also pass --target.

Approved by:	?
xDifferential Revision: https://reviews.freebsd.org/D31568

Test Plan

$ export CC=clang BINARY_ALIAS=cc=false
$ make clean all -C multimedia/librav1e

Diff Detail

Repository

R11 FreeBSD ports repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

jbeich requested review of this revision.Aug 16 2021, 7:30 PM

jbeich created this revision.

jbeich added a child revision: D31569: Mk/Uses/cargo.mk: always pass --target.Aug 16 2021, 7:40 PM

Drop target-specific LDFLAGS as -C link-arg in global RUSTFLAGS works fine

jbeich retitled this revision from Mk/Uses/cargo.mk: respect CC/LDFLAGS when --target is passed to Mk/Uses/cargo.mk: respect CC when --target is passed.Aug 16 2021, 8:55 PM

jbeich edited the summary of this revision. (Show Details)

I confirm, this fixes the issue (rust=rust-nightly).

tobik requested changes to this revision.Aug 21 2021, 8:02 AM

tobik added a subscriber: tobik.

tobik added inline comments.