Page MenuHomeFreeBSD
Differential D3155

Add devel/git-cola port.
ClosedPublic
Actions

Authored by jonathan on Jul 22 2015, 5:57 PM.
Tags
None
Referenced Files
F133681611: D3155.id7187.diff
Mon, Oct 27, 1:35 PM
Unknown Object (File)
Fri, Oct 24, 11:16 AM
Unknown Object (File)
Thu, Oct 23, 1:20 AM
Unknown Object (File)
Fri, Oct 17, 3:15 PM
Unknown Object (File)
Fri, Oct 17, 9:36 AM
Unknown Object (File)
Tue, Oct 14, 7:59 AM
Unknown Object (File)
Thu, Oct 2, 5:42 PM
Unknown Object (File)
Thu, Oct 2, 3:53 AM
View All Files
Subscribers
brd
brooks
pgollucci

Details

Reviewers
brd
Commits
rP397539: Add new port: devel/git-cola.
Summary

This is a nice-looking GUI for Git.

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

jonathan updated this revision to Diff 7186.Jul 22 2015, 5:57 PM
jonathan retitled this revision from to Add devel/git-cola port..
jonathan updated this object.
jonathan edited the test plan for this revision. (Show Details)
jonathan updated this revision to Diff 7187.Jul 22 2015, 6:06 PM

Apply some fixes from portlint -A.

pgollucci added a subscriber: pgollucci.Jul 22 2015, 6:48 PM
pgollucci added inline comments.
devel/git-cola/Makefile
10

mainter should be ports@ or yourself

brd added a subscriber: brd.Jul 22 2015, 6:51 PM
jonathan updated this revision to Diff 7190.Jul 22 2015, 6:51 PM
  • Change maintainer to ports@FreeBSD.org.
brd added inline comments.Jul 22 2015, 6:53 PM
devel/git-cola/Makefile
17

GH_ACCOUNT & GH_PROJECT can both be removed since they default to the value of ${PORTNAME}: https://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/book.html#makefile-master_sites-github-description

jonathan updated this revision to Diff 7191.Jul 22 2015, 6:56 PM
jonathan marked an inline comment as done.
  • Remove redundant GitHub information.
brooks added a subscriber: brooks.Jul 22 2015, 7:55 PM
brooks added inline comments.
devel/git-cola/Makefile
11

MAINTAINER should be submitter. We shouldn't commit pre-orphaned ports.

brd accepted this revision.Jul 22 2015, 8:18 PM
brd added a reviewer: brd.
This revision is now accepted and ready to land.Jul 22 2015, 8:18 PM
jonathan updated this revision to Diff 7223.Jul 23 2015, 2:16 PM
jonathan edited edge metadata.
jonathan marked an inline comment as done.
  • Add myself as port maintainer.
This revision now requires review to proceed.Jul 23 2015, 2:16 PM
brd accepted this revision.Jul 23 2015, 2:25 PM
brd edited edge metadata.
This revision is now accepted and ready to land.Jul 23 2015, 2:25 PM
Closed by commit rP397539: Add new port: devel/git-cola. (authored by jonathan). · Explain WhySep 22 2015, 2:00 PM
This revision was automatically updated to reflect the committed changes.
jonathan marked an inline comment as done.

Revision Contents
Changeset List

PathSize
devel/
git-cola/
21 lines
2 lines
3 lines
129 lines

Diff 7191

View Options

devel/git-cola/Makefile

Loading...
View Options

devel/git-cola/distinfo

Loading...
View Options

devel/git-cola/pkg-descr

Loading...
View Options

devel/git-cola/pkg-plist

Loading...