Page MenuHomeFreeBSD

Add devel/git-cola port.
ClosedPublic

Authored by jonathan on Jul 22 2015, 5:57 PM.

Details

Summary

This is a nice-looking GUI for Git.

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

jonathan updated this revision to Diff 7186.Jul 22 2015, 5:57 PM
jonathan retitled this revision from to Add devel/git-cola port..
jonathan updated this object.
jonathan edited the test plan for this revision. (Show Details)
jonathan updated this revision to Diff 7187.Jul 22 2015, 6:06 PM

Apply some fixes from portlint -A.

pgollucci added inline comments.
devel/git-cola/Makefile
9 ↗(On Diff #7187)

mainter should be ports@ or yourself

brd added a subscriber: brd.Jul 22 2015, 6:51 PM
jonathan updated this revision to Diff 7190.Jul 22 2015, 6:51 PM
  • Change maintainer to ports@FreeBSD.org.
brd added inline comments.Jul 22 2015, 6:53 PM
devel/git-cola/Makefile
16 ↗(On Diff #7187)

GH_ACCOUNT & GH_PROJECT can both be removed since they default to the value of ${PORTNAME}: https://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/book.html#makefile-master_sites-github-description

jonathan updated this revision to Diff 7191.Jul 22 2015, 6:56 PM
jonathan marked an inline comment as done.
  • Remove redundant GitHub information.
brooks added a subscriber: brooks.Jul 22 2015, 7:55 PM
brooks added inline comments.
devel/git-cola/Makefile
10 ↗(On Diff #7186)

MAINTAINER should be submitter. We shouldn't commit pre-orphaned ports.

brd accepted this revision.Jul 22 2015, 8:18 PM
brd added a reviewer: brd.
This revision is now accepted and ready to land.Jul 22 2015, 8:18 PM
jonathan updated this revision to Diff 7223.Jul 23 2015, 2:16 PM
jonathan edited edge metadata.
jonathan marked an inline comment as done.
  • Add myself as port maintainer.
This revision now requires review to proceed.Jul 23 2015, 2:16 PM
brd accepted this revision.Jul 23 2015, 2:25 PM
brd edited edge metadata.
This revision is now accepted and ready to land.Jul 23 2015, 2:25 PM
This revision was automatically updated to reflect the committed changes.
jonathan marked an inline comment as done.