Page MenuHomeFreeBSD

vt: Unbreak build on no-splash configurations
ClosedPublic

Authored by cem on Jul 22 2015, 2:06 PM.
Tags
None
Referenced Files
F157429393: D3151.id7178.diff
Thu, May 21, 8:52 AM
Unknown Object (File)
Tue, May 19, 7:11 PM
Unknown Object (File)
Tue, May 19, 12:26 PM
Unknown Object (File)
Tue, May 19, 12:20 PM
Unknown Object (File)
Mon, May 18, 9:14 AM
Unknown Object (File)
Sun, May 17, 6:19 PM
Unknown Object (File)
Sun, May 17, 6:13 PM
Unknown Object (File)
Sun, May 17, 6:51 AM

Details

Reviewers
markj
Summary

Fake unused variables/functions in DEV_SPLASH. Their uses were hidden behind
'if (0)', but I guess the compiler was unconvinced.

Test Plan

It builds on a no-DEV_SPLASH AMD64.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage

Event Timeline

cem retitled this revision from to vt: Unbreak build on no-splash configurations.
cem updated this object.
cem edited the test plan for this revision. (Show Details)
cem added a reviewer: markj.

After this patch ARM build and console boot fine (tested r285792)

uname -a

FreeBSD bb.local 11.0-CURRENT FreeBSD 11.0-CURRENT #1 r285792M: Wed Jul 22 17:34:24 MSK 2015 root@des.local:/usr/obj/arm.armv6/usr/src/sys/BEAGLEBONE-IPv6 arm

markj edited edge metadata.
This revision is now accepted and ready to land.Jul 22 2015, 3:24 PM

Hi Conrad,

Yes, this fix the build of the Raspberry Pi kernel.

Thanks!