Page MenuHomeFreeBSD
Differential D3136

Add a few uses introduced by @bapt
ClosedPublic
Actions

Authored by mat on Jul 20 2015, 2:21 PM.
Tags
None
Referenced Files
Unknown Object (File)
Apr 21 2024, 7:43 AM
Unknown Object (File)
Apr 19 2024, 3:15 PM
Unknown Object (File)
Jan 11 2024, 9:50 AM
Unknown Object (File)
Dec 23 2023, 4:23 AM
Unknown Object (File)
Nov 12 2023, 4:02 AM
Unknown Object (File)
Nov 9 2023, 7:12 AM
Unknown Object (File)
Nov 8 2023, 3:29 PM
Unknown Object (File)
Nov 7 2023, 10:55 PM
View All 84 Files
Subscribers
None

Details

Reviewers
gjb
wblock
Commits
rD47054: Document USES=libarchive, libedit and localbase.
Summary

http://aragorn.in.absolight.net/d2/other-uses/en_US.ISO8859-1/books/porters-handbook/uses.html

Diff Detail

Repository
rD FreeBSD doc repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

mat updated this revision to Diff 7099.Jul 20 2015, 2:21 PM
mat retitled this revision from to Add a few uses introduced by @bapt.
mat updated this object.
mat edited the test plan for this revision. (Show Details)
mat added reviewers: wblock, gjb.
wblock added inline comments.Jul 20 2015, 6:57 PM
en_US.ISO8859-1/books/porters-handbook/uses/chapter.xml
770 ↗(On Diff #7099)

s/port/ports/

772 ↗(On Diff #7099)

"use it" is vague. Maybe:

Any port that depends on archivers/libarchive must include this entry.

That can probably be done better. Maybe "must include this USES= entry"?

782 ↗(On Diff #7099)

Same as above, both with s/port/ports/ and the rest of the sentence.

807 ↗(On Diff #7099)

I don't know what "Handles enforcing LOCALBASE" means. If I don't include this entry in a port, does that mean it is free to write outside of LOCALBASE?

mat marked 2 inline comments as done.Jul 21 2015, 10:08 AM
mat added inline comments.
en_US.ISO8859-1/books/porters-handbook/uses/chapter.xml
807 ↗(On Diff #7099)

Ah, well, LOCALBASE is where what your dependencies are installed, not where you write things, you write things in PREFIX so it was clear for me. ?

mat marked an inline comment as done.Jul 21 2015, 10:09 AM
mat updated this revision to Diff 7127.Jul 21 2015, 10:10 AM

Update.

mat marked an inline comment as done.Jul 21 2015, 10:10 AM
mat updated this revision to Diff 7128.Jul 21 2015, 10:12 AM

Rewrite.

mat updated this revision to Diff 7129.Jul 21 2015, 10:13 AM
  • Again.
wblock added inline comments.Jul 21 2015, 2:28 PM
en_US.ISO8859-1/books/porters-handbook/uses/chapter.xml
808 ↗(On Diff #7129)

This is better. "Handles enforcing" is still a questionable term, because "handles" can be read as a noun. The actual meaning is not clear, whether this is something that helps the port author, or improves reliability of a port, or what.

An example (probably wrong, but...):
Restricts the port to only calling shared libraries in LOCALBASE.

811 ↗(On Diff #7129)

The other thing missing here is how the porter knows when they need to add this to their port.

Ports that use libraries from the XYZ port must/should/can include this option/macro to ensure that...

mat marked 3 inline comments as done.Jul 21 2015, 2:35 PM
mat added inline comments.
en_US.ISO8859-1/books/porters-handbook/uses/chapter.xml
808 ↗(On Diff #7129)

Mmmm, it's not exactly true, it's just putting LOCALBASE/lib before /usr/lib. Let me see what I can write.

811 ↗(On Diff #7129)

right.

mat updated this revision to Diff 7142.Jul 21 2015, 2:38 PM
mat marked 2 inline comments as done.
  • Rewrite.
mat marked 2 inline comments as done.Jul 21 2015, 2:39 PM
wblock added inline comments.Jul 21 2015, 3:45 PM
en_US.ISO8859-1/books/porters-handbook/uses/chapter.xml
808 ↗(On Diff #7142)

That makes a lot more sense. It doesn't really "force" that, then, it just adjusts the path so that if they are present in LOCALBASE, they will be used in preference to the base ones.

810 ↗(On Diff #7142)

Typos:
s/librairies/libraries/
s/depends/depend/

mat marked 2 inline comments as done.Jul 22 2015, 10:53 AM
mat added inline comments.
en_US.ISO8859-1/books/porters-handbook/uses/chapter.xml
808 ↗(On Diff #7142)

Yes, it doesn't force anything, but explaining it more would mean giving away implementation details that could change while the spirit of it does not.

mat updated this revision to Diff 7171.Jul 22 2015, 10:54 AM
mat marked an inline comment as done.
  • typos.
wblock added inline comments.Jul 22 2015, 3:14 PM
en_US.ISO8859-1/books/porters-handbook/uses/chapter.xml
828 ↗(On Diff #7171)

Maybe

Ensures that libraries from dependencies in LOCALBASE are used instead of...

831 ↗(On Diff #7171)

Probably should say

also present in the base system should use this. It is also

mat marked 3 inline comments as done.Jul 23 2015, 11:48 AM
mat updated this revision to Diff 7219.Jul 23 2015, 11:48 AM
  • reword
wblock accepted this revision.Jul 23 2015, 2:00 PM
wblock edited edge metadata.

Thanks!

This revision is now accepted and ready to land.Jul 23 2015, 2:00 PM
Closed by commit rD47054: Document USES=libarchive, libedit and localbase. (authored by mat). · Explain WhyJul 23 2015, 2:14 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
head/
en_US.ISO8859-1/
books/
porters-handbook/
uses/
35 lines

Diff 7222

View Options

head/en_US.ISO8859-1/books/porters-handbook/uses/chapter.xml

Loading...