Differential D31335

genassym.sh: Fix two minor issues found by shellcheck
ClosedPublic
Actions

Authored by imp on Jul 28 2021, 5:28 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Thu, Jun 25, 1:29 PM

	Unknown Object (File)
	Wed, Jun 24, 5:25 AM

	Unknown Object (File)
	Sat, Jun 20, 6:02 PM

	Unknown Object (File)
	Fri, Jun 19, 11:35 PM

	Unknown Object (File)
	Mon, Jun 8, 3:13 PM

	Unknown Object (File)
	May 27 2026, 3:58 PM

	Unknown Object (File)
	May 9 2026, 9:25 PM

	Unknown Object (File)
	May 8 2026, 11:31 AM

Subscribers

None

Details

Reviewers

kib
markj

Commits

rG5bdfcb07f38a: genassym.sh: Fix two minor issues found by shellcheck
rGe961e7dc00ab: genassym.sh: Fix two minor issues found by shellcheck
rG46dd3ef0338b: genassym.sh: Fix two minor issues found by shellcheck

Summary

o Remove redunant $ in $(( )) expression.
o Quote arg passed to work so paths with spaces, etc will work.

Sponsored by: Netflix

Test Plan

based on feedback from shellcheck and the genoffset.sh review, I've tweaked this

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

imp requested review of this revision.Jul 28 2021, 5:28 PM

imp created this revision.

Harbormaster completed remote builds in B40727: Diff 92892.Jul 28 2021, 5:28 PM

imp edited the test plan for this revision. (Show Details)Jul 28 2021, 5:28 PM

imp added reviewers: kib, markj.

kib accepted this revision.Jul 28 2021, 6:36 PM

This revision is now accepted and ready to land.Jul 28 2021, 6:36 PM

Closed by commit rG46dd3ef0338b: genassym.sh: Fix two minor issues found by shellcheck (authored by imp). · Explain WhyJul 28 2021, 7:55 PM

This revision was automatically updated to reflect the committed changes.

imp added a commit: rG46dd3ef0338b: genassym.sh: Fix two minor issues found by shellcheck.

imp added a commit: rGe961e7dc00ab: genassym.sh: Fix two minor issues found by shellcheck.Sep 12 2021, 4:35 PM

imp added a commit: rG5bdfcb07f38a: genassym.sh: Fix two minor issues found by shellcheck.Sep 12 2021, 6:33 PM

Revision Contents
Changeset List

Path

Size

sys/

kern/

6 lines

Diff 92897

sys/kern/genassym.sh

Loading...