Page MenuHomeFreeBSD
Differential D31335

genassym.sh: Fix two minor issues found by shellcheck
ClosedPublic
Actions

Authored by imp on Jul 28 2021, 5:28 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Mar 14, 11:34 PM
Unknown Object (File)
Wed, Mar 12, 5:16 PM
Unknown Object (File)
Feb 22 2025, 2:37 PM
Unknown Object (File)
Feb 22 2025, 1:17 PM
Unknown Object (File)
Feb 22 2025, 10:46 AM
Unknown Object (File)
Feb 21 2025, 10:22 PM
Unknown Object (File)
Feb 10 2025, 5:27 PM
Unknown Object (File)
Feb 8 2025, 11:24 PM
View All 55 Files
Subscribers
None

Details

Reviewers
kib
markj
Commits
rG5bdfcb07f38a: genassym.sh: Fix two minor issues found by shellcheck
rGe961e7dc00ab: genassym.sh: Fix two minor issues found by shellcheck
rG46dd3ef0338b: genassym.sh: Fix two minor issues found by shellcheck
Summary

o Remove redunant $ in $(( )) expression.
o Quote arg passed to work so paths with spaces, etc will work.

Sponsored by: Netflix

Test Plan

based on feedback from shellcheck and the genoffset.sh review, I've tweaked this

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSize
sys/
kern/
6 lines

Diff 92897

View Options

sys/kern/genassym.sh

Show First 20 Lines • Show All 51 Lines • ▼ Show 20 Lines
while getopts "o:" option while getopts "o:" option
do do
case "$option" in case "$option" in
o) outfile="$OPTARG" o) outfile="$OPTARG"
use_outfile="yes";; use_outfile="yes";;
*) usage;; *) usage;;
esac esac
done done
shift $(($OPTIND - 1)) shift $((OPTIND - 1))
case $# in case $# in
1) ;; 1) ;;
*) usage;; *) usage;;
esac esac
if [ "$use_outfile" = "yes" ] if [ "$use_outfile" = "yes" ]
then then
work $1 3>"$outfile" >&3 3>&- work "$1" 3>"$outfile" >&3 3>&-
else else
work $1 work "$1"
fi fi