Page MenuHomeFreeBSD
Differential D3127

Edit PCID report based on @wblock feedback
ClosedPublic
Actions

Authored by emaste on Jul 19 2015, 1:07 PM.
Tags
None
Referenced Files
Unknown Object (File)
Dec 4 2024, 11:12 PM
Unknown Object (File)
Dec 4 2024, 8:42 AM
Unknown Object (File)
Nov 29 2024, 9:37 PM
Unknown Object (File)
Nov 23 2024, 4:23 PM
Unknown Object (File)
Nov 19 2024, 11:36 AM
Unknown Object (File)
Nov 19 2024, 11:28 AM
Unknown Object (File)
Nov 6 2024, 1:12 PM
Unknown Object (File)
Nov 6 2024, 11:28 AM
View All 98 Files
Subscribers
None

Details

Reviewers
kib
wblock
Commits
rD47019: Update PCID report based on some feedback from wblock

Diff Detail

Repository
rD FreeBSD doc repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

emaste updated this revision to Diff 7072.Jul 19 2015, 1:07 PM
emaste retitled this revision from to Edit PCID report based on @wblock feedback.
emaste updated this object.
emaste edited the test plan for this revision. (Show Details)
emaste added reviewers: wblock, kib.
wblock edited edge metadata.Jul 19 2015, 1:56 PM

svn diff --diff-cmd=diff -x -U999999 can be used to keep full context. (From https://wiki.freebsd.org/CodeReview, which was pointed out to me a few days ago.)

report-2015-04-2015-06.xml
1091 ↗(On Diff #7072)

I added the expansion of TLB, please verify.

1132 ↗(On Diff #7072)

This last sentence implies a conclusion that this is either good, or at least no worse than the pmap implementation. Can we have another sentence that tells why that is good?

emaste added inline comments.Jul 19 2015, 2:03 PM
report-2015-04-2015-06.xml
1091 ↗(On Diff #7072)

Yes it is correct

1132 ↗(On Diff #7072)

Maybe This avoids the possible performance degradation that extra TLB shootdowns would cause.

kib accepted this revision.Jul 19 2015, 4:38 PM
kib edited edge metadata.
kib added inline comments.
report-2015-04-2015-06.xml
1114 ↗(On Diff #7072)

the TLB IPI rate

1132 ↗(On Diff #7072)

Later in the text.

<p>Measurements done with hwpmc(4) on a Haswell machine indicated
that the new implementation reduced the amount of data TLB misses
up to 10x times, without an impact on the IPI counters.</p>
This revision is now accepted and ready to land.Jul 19 2015, 4:38 PM
wblock accepted this revision.Jul 19 2015, 7:04 PM
wblock edited edge metadata.
emaste updated this revision to Diff 7077.Jul 19 2015, 7:22 PM
emaste edited edge metadata.

Restore missing paragraphs

This revision now requires review to proceed.Jul 19 2015, 7:22 PM
emaste added inline comments.Jul 19 2015, 7:28 PM
report-2015-04-2015-06.xml
1139 ↗(On Diff #7077)

Perhaps reduced the TLB miss rate by up to 10 times, without increasing TLB shootdown IPIs?

emaste updated this revision to Diff 7079.Jul 19 2015, 7:35 PM
emaste edited edge metadata.

Rebase after @wblock's commit

wblock accepted this revision.Jul 19 2015, 7:40 PM
wblock edited edge metadata.

Ignoring the comments (Phabricator can't deal with the number of lines in a diff changing), this looks good. I suggest we commit.

This revision is now accepted and ready to land.Jul 19 2015, 7:40 PM
Closed by commit rD47019: Update PCID report based on some feedback from wblock (authored by emaste). · Explain WhyJul 19 2015, 7:59 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
head/
en_US.ISO8859-1/
htdocs/
news/
status/
27 lines

Diff 7080

View Options

head/en_US.ISO8859-1/htdocs/news/status/report-2015-04-2015-06.xml

Loading...