Page MenuHomeFreeBSD

linux(4): Replace casuword32 by casueword32 in handle_futex_death().
ClosedPublic

Authored by dchagin on Wed, Jul 21, 7:40 AM.

Diff Detail

Repository
R10 FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

kib added inline comments.
sys/compat/linux/linux_futex.c
1004–1005

This is fine as the step, but please look at 30b3018d48e4441083b483

This revision is now accepted and ready to land.Wed, Jul 21, 8:05 AM
sys/compat/linux/linux_futex.c
1004–1005

sure, did I understand correctly that on ll/sc architectures casueword can fails as there are two operations,
and exceptional events between this operations can lead the second operation (store-conditional) to spuriously fail.
So before repeating we need a check for stops etc...?
If so, I need to revise all of new futex code ))

sys/compat/linux/linux_futex.c
1004–1005

Right. Generally casueword is allowed to spuriously fail on all arches, same as cmpset/fcmpset.

Follow the r349951 (30b3018d), add check to react to stops and requests
to terminate between retries.

This revision now requires review to proceed.Wed, Jul 21, 7:06 PM
kib added inline comments.
sys/compat/linux/linux_futex.c
1001

error != 0

This revision is now accepted and ready to land.Wed, Jul 21, 7:36 PM