Page MenuHomeFreeBSD
Differential D31219

sesutil: Fix status checking
ClosedPublic
Actions

Authored by trasz on Jul 19 2021, 4:28 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Apr 30, 7:58 PM
Unknown Object (File)
Thu, Apr 25, 8:48 PM
Unknown Object (File)
Thu, Apr 25, 8:45 PM
Unknown Object (File)
Wed, Apr 24, 10:02 PM
Unknown Object (File)
Fri, Apr 19, 4:05 PM
Unknown Object (File)
Apr 7 2024, 2:59 PM
Unknown Object (File)
Mar 12 2024, 1:17 AM
Unknown Object (File)
Mar 12 2024, 1:17 AM
View All 27 Files
Subscribers
allanjude
imp

Details

Reviewers
allanjude
Commits
rG5b8c67766471: sesutil: Fix status checking
rGa15719671352: sesutil: Fix status checking
Summary

Previously we would display "OK, Swapped" for swapped disks, instead
of the usual disk size.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

trasz created this revision.Jul 19 2021, 4:28 PM
Herald added a subscriber: imp. · View Herald TranscriptJul 19 2021, 4:28 PM
trasz requested review of this revision.Jul 19 2021, 4:28 PM
Harbormaster completed remote builds in B40529: Diff 92429.Jul 19 2021, 4:28 PM
allanjude accepted this revision.Jul 19 2021, 4:40 PM
allanjude added a subscriber: allanjude.

Reviewed By: allanjude

this changes the output from:

ses0: <SMC SC846P 0c1f>; ID: 500304801820593f
Desc     Dev     Model                     Ident                Size/Status
Slot05   da5     HGST HUS726060AL4210      NCH4652Z             6T
Slot06   da6     HGST HUS726060AL4210      K1GT8JTD             6T
Slot07   da7     HGST HUS726060AL4210      NCH45KAZ             OK,  Swapped

to:

ses0: <SMC SC846P 0c1f>; ID: 500304801820593f
Desc     Dev     Model                     Ident                Size/Status
Slot05   da5     HGST HUS726060AL4210      NCH4652Z             6T
Slot06   da6     HGST HUS726060AL4210      K1GT8JTD             6T
Slot07   da7     HGST HUS726060AL4210      NCH45KAZ             6T,  Swapped

which is much more useful.

This revision is now accepted and ready to land.Jul 19 2021, 4:40 PM
trasz added a comment.Jul 21 2021, 9:13 AM

(Tinderboxed.)

Closed by commit rGa15719671352: sesutil: Fix status checking (authored by trasz). · Explain WhyJul 21 2021, 9:15 AM
This revision was automatically updated to reflect the committed changes.
trasz added a commit: rGa15719671352: sesutil: Fix status checking.
trasz added a commit: rG5b8c67766471: sesutil: Fix status checking.Feb 18 2022, 2:52 PM

Revision Contents
Changeset List

PathSize
usr.sbin/
sesutil/
2 lines

Diff 92564

View Options

usr.sbin/sesutil/sesutil.c

Loading...