stand/kmem_zalloc: panic when a M_WAITOK allocation fails
ClosedPublic
Actions

Authored by imp on Jul 8 2021, 5:41 AM.

Details

Reviewers

tsoome
kevans

Commits

rG9cd9a0c86924: stand/kmem_zalloc: panic when a M_WAITOK allocation fails
rG72821668b039: stand/kmem_zalloc: panic when a M_WAITOK allocation fails

Summary

Malloc() might return NULL, in which case we will panic with a NULL
pointer deref. Make it panic when the allocation fails to preserve the
postcondtion that we never return a non-NULL value.

PR: 249859
Sponsored by: Netflix

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

imp requested review of this revision.Jul 8 2021, 5:41 AM

imp created this revision.

Harbormaster completed remote builds in B40386: Diff 91963.Jul 8 2021, 5:41 AM

imp added reviewers: tsoome, kevans.Jul 8 2021, 5:42 AM

imp added inline comments.

sys/sys/malloc.h
322	This crept in because we never were testing flags before.

tsoome added inline comments.Jul 8 2021, 6:30 AM

sys/sys/malloc.h
308	Shouldn't this order be reversed? or maybe create inline [function] instead? just thinking...

imp added inline comments.Jul 8 2021, 10:30 PM

sys/sys/malloc.h
308	Order of what? It can't be an inline function because I want FILE and LINE and I didn't see a good way to get that with an inline function.
309	This should be if (p == 0 && (flags & M_WAITOK) != 0)