Details
- Reviewers
gjb wblock - Commits
- rD47032: Add a note saying not to use := in *_DEPENDS variables.
Diff Detail
- Repository
- rD FreeBSD doc repository - subversion
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
This is good. Show the right way to do it, and then only after that tell (but do not show) the wrong way to do it.
| en_US.ISO8859-1/books/porters-handbook/makefiles/chapter.xml | ||
|---|---|---|
| 3295 ↗ | (On Diff #7021) | Use <emphasis> around "Do not", or at least "not". |
| 3299 ↗ | (On Diff #7021) | Avoid the informal "you". For things that are not to be used, don't suggest that they might work some of the time. All variables are expanded immediately, which is exactly the wrong thing to do and almost always a failure. |
| en_US.ISO8859-1/books/porters-handbook/makefiles/chapter.xml | ||
|---|---|---|
| 3295 ↗ | (On Diff #7021) | I started with it, but <emphasis> puts stuff in italics, and an <important> block is already in italics, but you're right, I should not be tagging for rendering. |
Please remember to check with igor before commit. Thanks!
| en_US.ISO8859-1/books/porters-handbook/makefiles/chapter.xml | ||
|---|---|---|
| 3295 ↗ | (On Diff #7098) | True. It does not render the <emphasis> stuff different from that around it, which is a stylesheet bug. That is something I'd like to fix, but not something I can look at immediately. gabor@ is probably the best person to contact. |