Page MenuHomeFreeBSD
Differential D31073

Hack at the moment: see if devclass_is_derived_from helps...
AbandonedPublic
Actions

Authored by imp on Jul 6 2021, 7:11 AM.
Tags
None
Referenced Files
F156736807: D31073.id91850.diff
Sat, May 16, 12:24 AM
F156736752: D31073.diff
Sat, May 16, 12:23 AM
F156736719: D31073.diff
Sat, May 16, 12:23 AM
Unknown Object (File)
Mon, May 4, 6:24 AM
Unknown Object (File)
Sat, May 2, 5:38 AM
Unknown Object (File)
Sat, May 2, 3:10 AM
Unknown Object (File)
Mon, Apr 27, 5:17 PM
Unknown Object (File)
Apr 15 2026, 11:04 AM
View All 78 Files
Subscribers
nc

Details

Reviewers
jhb
nc
Summary

Sponsored by: Netflix

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 40342
Build 37231: arc lint + arc unit

Event Timeline

imp requested review of this revision.Jul 6 2021, 7:11 AM
imp created this revision.
Harbormaster completed remote builds in B40342: Diff 91850.Jul 6 2021, 7:11 AM
imp mentioned this in D31071: vmd: Rename vmd_bus class to pci.Jul 6 2021, 7:22 AM
imp added a reviewer: jhb.Jul 6 2021, 7:28 AM
nc accepted this revision.Jul 7 2021, 1:45 AM
nc added a subscriber: nc.

I think it looks fine.

I'd recommend waiting for jhb@ since I'm not really a "kernel" hacker and technically a Ports committer, just one getting very active in the kernel.

This revision is now accepted and ready to land.Jul 7 2021, 1:45 AM
imp added a comment.Jul 7 2021, 1:47 AM
In D31073#699326, @nc wrote:

I think it looks fine.

Does it work for you?

I'd recommend waiting for jhb@ since I'm not really a "kernel" hacker and technically a Ports committer, just one getting very active in the kernel.

Yes. I think so too

nc requested changes to this revision.Jul 7 2021, 5:29 AM

Update: This patch gives me the same kernel panic as before. Therefore I pull my "approval".

This revision now requires changes to proceed.Jul 7 2021, 5:29 AM
imp abandoned this revision.Sep 30 2021, 1:42 AM

Revision Contents
Changeset List

PathSize
sys/
dev/
pci/
6 lines
kern/
17 lines
sys/
1 line

Diff 91850

View Options

sys/dev/pci/pci.c

Loading...
View Options

sys/kern/subr_bus.c

Loading...
View Options

sys/sys/bus.h

Loading...