Differential D3107

Fix ARM64 stack calculation
ClosedPublic
Actions

Authored by wma_semihalf.com on Jul 16 2015, 8:23 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sat, Jan 25, 8:42 PM

	Unknown Object (File)
	Fri, Jan 24, 11:13 PM

	Unknown Object (File)
	Wed, Jan 22, 7:35 AM

	Unknown Object (File)
	Jan 17 2025, 10:33 PM

	Unknown Object (File)
	Jan 17 2025, 9:18 AM

	Unknown Object (File)
	Jan 17 2025, 7:20 AM

	Unknown Object (File)
	Jan 14 2025, 9:46 PM

	Unknown Object (File)
	Jan 13 2025, 5:51 PM

Subscribers

freebsd-arm-list

Details

Reviewers

zbb
emaste
andoriyu_gmail.com

Commits

rS285654: Fix secondary stacks calculation on ARM64

Summary

Fixes in locore.s:
 - opt_kstack_pages.h include was added to ensure the proper
   KSTACK_PAGES value is used
 - secondary stack calculation is modified to provide
   stack_top = secondary_stacks + (cpu_id)*PAGE_SIZE*KSTACK_PAGES
   because on ARMv8 the stack grows into lower memory addresses

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

wma_semihalf.com updated this revision to Diff 7001.Jul 16 2015, 8:23 AM

wma_semihalf.com retitled this revision from to Fix ARM64 stack calculation.

wma_semihalf.com updated this object.

wma_semihalf.com edited the test plan for this revision. (Show Details)

wma_semihalf.com added reviewers: andoriyu_gmail.com, emaste, zbb.

wma_semihalf.com set the repository for this revision to rS FreeBSD src repository - subversion.

wma_semihalf.com added a subscriber: freebsd-arm-list.

Herald added subscribers: emaste, andrew, imp. · View Herald TranscriptJul 16 2015, 8:23 AM

wma_semihalf.com updated this revision to Diff 7002.Jul 16 2015, 8:27 AM

zbb accepted this revision.Jul 17 2015, 9:52 AM

zbb edited edge metadata.

This revision is now accepted and ready to land.Jul 17 2015, 9:52 AM

Closed by commit rS285654: Fix secondary stacks calculation on ARM64 (authored by zbb). · Explain WhyJul 17 2015, 2:08 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

head/

sys/

arm64/

arm64/

3 lines

Diff 7046

head/sys/arm64/arm64/locore.S

Loading...