Page MenuHomeFreeBSD

loader: Don't reserve space for symbols twice.
ClosedPublic

Authored by imp on Jul 4 2021, 4:11 PM.

Details

Summary

The current code bumps lastaddr twice for the symbol table
location. However, the first bump is bogus and results in wasted
space. Remove it.

PR: 110995

Diff Detail

Repository
R10 FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

imp requested review of this revision.Jul 4 2021, 4:11 PM
imp added a reviewer: jhb.
stand/common/load_elf_obj.c
293–295

I think we already do the stuff above here, so we can just do these lines and omit them above.

imp retitled this revision from don't load symbol table into memory to loader: Don't reserve space for symbols twice..Jul 4 2021, 4:40 PM
imp edited the summary of this revision. (Show Details)
imp added a reviewer: neel.
imp edited the summary of this revision. (Show Details)

actually remove... no need to comment these redunant lines out.

This revision was not accepted when it landed; it landed in state Needs Review.Jul 12 2021, 9:31 PM
This revision was automatically updated to reflect the committed changes.