Page MenuHomeFreeBSD

amd64: a simplication to pmap_remove_{all,write}
ClosedPublic

Authored by alc on Jun 30 2021, 5:58 AM.

Details

Summary

Eliminate some unnecessary unlocking and relocking when we have to retry the operation to avoid deadlock. (All of the other pmap functions that iterate over a PV list already implemented retries without these same unlocking and relocking operations.)

Diff Detail

Repository
rG FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

alc requested review of this revision.Jun 30 2021, 5:58 AM
alc created this revision.
kib added inline comments.
sys/amd64/amd64/pmap.c
8509

Why did you left out the spin chunk from there? Because it would require larger change to fcmset to re-read oldpte to avoid loosing PG_M?

This revision is now accepted and ready to land.Jun 30 2021, 6:06 AM
alc marked an inline comment as done.Jun 30 2021, 6:11 PM
alc added inline comments.
sys/amd64/amd64/pmap.c
8509

Yes. I'll try doing it separately.

This revision was automatically updated to reflect the committed changes.
alc marked an inline comment as done.