Differential D30951

amd64: a simplication to pmap_remove_{all,write}
ClosedPublic
Actions

Authored by alc on Jun 30 2021, 5:58 AM.

Tags

None

Subscribers

None

Details

Reviewers

kib
markj

Commits

rG1a8bcf30f97e: amd64: a simplication to pmap_remove_{all,write}

Summary

Eliminate some unnecessary unlocking and relocking when we have to retry the operation to avoid deadlock. (All of the other pmap functions that iterate over a PV list already implemented retries without these same unlocking and relocking operations.)

Diff Detail

Repository

rG FreeBSD src repository

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

alc requested review of this revision.Jun 30 2021, 5:58 AM

alc created this revision.

kib accepted this revision.Jun 30 2021, 6:06 AM

kib added inline comments.

sys/amd64/amd64/pmap.c
8509	Why did you left out the spin chunk from there? Because it would require larger change to fcmset to re-read oldpte to avoid loosing PG_M?

This revision is now accepted and ready to land.Jun 30 2021, 6:06 AM

markj accepted this revision.Jun 30 2021, 12:20 PM

alc marked an inline comment as done.Jun 30 2021, 6:11 PM

alc added inline comments.

sys/amd64/amd64/pmap.c
8509	Yes. I'll try doing it separately.

Closed by commit rG1a8bcf30f97e: amd64: a simplication to pmap_remove_{all,write} (authored by alc). · Explain WhyJun 30 2021, 6:15 PM

This revision was automatically updated to reflect the committed changes.

alc marked an inline comment as done.

alc added a commit: rG1a8bcf30f97e: amd64: a simplication to pmap_remove_{all,write}.

Revision Contents
Changeset List

Path

Size

sys/

amd64/

amd64/

8 lines

Diff 91580

sys/amd64/amd64/pmap.c

Loading...