Differential D30734

id: sanitize arguments better
ClosedPublic
Actions

Authored by asomers on Jun 11 2021, 4:40 PM.

Tags

None

Referenced Files

	F169184096: D30734.diff
	Mon, Aug 31, 6:12 PM

	F169111416: D30734.id.diff
	Mon, Aug 31, 10:58 AM

	Unknown Object (File)
	Sun, Aug 30, 12:27 PM

	Unknown Object (File)
	Sun, Aug 30, 10:56 AM

	Unknown Object (File)
	Sat, Aug 29, 6:35 PM

	Unknown Object (File)
	Thu, Aug 27, 1:43 PM

	Unknown Object (File)
	Wed, Aug 26, 11:25 AM

	Unknown Object (File)
	Wed, Aug 26, 2:43 AM

Subscribers

Details

Reviewers

Commits

rG5d7ae6fbb117: id: sanitize arguments better
rGbc997ea6b81e: id: sanitize arguments better
rG4a06e9377398: id: sanitize arguments better

Summary

The -[AMc] flags ignore the user argument. Better if id rejects
invocations that include a user argument along with any of those flags.

PR: 256554
MFC after: 2 weeks
Sponsored by: Axcient

Test Plan

manually tested with all command line options

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

asomers created this revision.Jun 11 2021, 4:40 PM

Herald added a subscriber: imp. · View Herald TranscriptJun 11 2021, 4:40 PM

asomers requested review of this revision.Jun 11 2021, 4:40 PM

Harbormaster completed remote builds in B39849: Diff 90744.Jun 11 2021, 4:40 PM

trasz accepted this revision.Jun 15 2021, 8:52 AM

This revision is now accepted and ready to land.Jun 15 2021, 8:52 AM

Closed by commit rG4a06e9377398: id: sanitize arguments better (authored by asomers). · Explain WhyJun 15 2021, 12:52 PM

This revision was automatically updated to reflect the committed changes.

asomers added a commit: rG4a06e9377398: id: sanitize arguments better.

asomers added a commit: rGbc997ea6b81e: id: sanitize arguments better.Jul 3 2021, 11:30 PM

asomers added a commit: rG5d7ae6fbb117: id: sanitize arguments better.Jul 4 2021, 4:15 AM

Revision Contents
Changeset List

Path

Size

usr.bin/

id/

2 lines

Diff 90917

usr.bin/id/id.c

Loading...