Page MenuHomeFreeBSD

xen/intr: partially revert "xen: fix IPI setup with EARLY_AP_STARTUP"
AbandonedPublic

Authored by ehem_freebsd_m5p.com on Jun 11 2021, 2:53 PM.
Tags
None
Referenced Files
Unknown Object (File)
Dec 20 2023, 4:29 AM
Unknown Object (File)
Dec 11 2023, 7:31 AM
Unknown Object (File)
Sep 2 2023, 8:00 PM
Unknown Object (File)
Aug 15 2023, 9:25 PM
Unknown Object (File)
Jun 16 2023, 3:39 AM
Unknown Object (File)
Jun 3 2023, 8:26 AM
Subscribers

Details

Summary

Better to have a single use of device_get_nameunit() inside
xen_intr_bind_isrc(), than four outside of it. This is rather more
valuable since there is work in progress which requires the device be
available inside xen_intr_bind_isrc().

This partially reverts ca7af67ac958d3749ebfc4771cecf0cd7525e6a0.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 39843
Build 36732: arc lint + arc unit

Event Timeline

This needs checking, I'm mostly testing on ARM. I think what this does shouldn't recreate the breakage ca7af67ac958d3749ebfc4771cecf0cd7525e6a0 was trying to fix, but I'm not 100% certain.

Bigger issue now that I think about it is I may be propagating the wrong device_t here. Issue is this code is an interrupt controller and the ARM side needs a device_t for intr_isrc_register(), and that should be a device number from this code; not one propagated from an interrupt sink.

I think this can be made unnecessary. Feels like this needs to wait for other pieces before any decisions are made.

I've made builds which behaved appropriately without this commit. As such this appears unnecessary, so time to abandon it.