Paths

Table of Contentst

qlnxe: Fix a use-after-free in ecore_spq_post()
Needs ReviewPublic
Actions

Authored by markj on Jun 2 2021, 2:10 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Wed, Aug 12, 10:36 PM

	Unknown Object (File)
	Tue, Aug 11, 4:44 PM

	Unknown Object (File)
	Mon, Aug 10, 3:38 AM

	Unknown Object (File)
	Sun, Aug 9, 3:19 AM

	Unknown Object (File)
	Sat, Aug 8, 6:51 PM

	Unknown Object (File)
	Sat, Aug 8, 7:51 AM

	Unknown Object (File)
	Fri, Aug 7, 4:15 AM

	Unknown Object (File)
	Tue, Aug 4, 8:52 AM

View All 92 Files

Subscribers

emaste

imp

info_dominicschlegel.ch

Details

Reviewers

davidcs

Summary

ecore_sqp_add_entry() may free the spq entry structure. Then,
ecore_spq_post() may dereference the entry to check
p_ent->comp_mode == ECORE_SPQ_MODE_EBLOCK.

Fix the problem by changing ecore_sqp_add_entry() to return the new
entry pointer.

PR: 255868
MFC after: 1 week

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 39663
Build 36552: arc lint + arc unit

Event Timeline

markj created this revision.Jun 2 2021, 2:10 PM

Herald added a subscriber: imp. · View Herald TranscriptJun 2 2021, 2:10 PM

markj requested review of this revision.Jun 2 2021, 2:10 PM

Harbormaster completed remote builds in B39663: Diff 90321.Jun 2 2021, 2:10 PM

emaste added a subscriber: emaste.Jun 2 2021, 10:43 PM

info_dominicschlegel.ch added a subscriber: info_dominicschlegel.ch.Oct 21 2021, 9:44 AM

Revision Contents
Changeset List

Path

Size

sys/

dev/

qlnx/

qlnxe/

ecore_spq.c

12 lines

Diff 90321

View Options

sys/dev/qlnx/qlnxe/ecore_spq.c

qlnxe: Fix a use-after-free in ecore_spq_post()Needs ReviewPublicActions