x86: initialize initial FPU state earlier
ClosedPublic
Actions

Authored by kib on May 27 2021, 4:37 PM.

Tags

None

Referenced Files

	F108890004: D30512.diff
	Wed, Jan 29, 4:43 AM

	F108882427: D30512.diff
	Wed, Jan 29, 2:21 AM

	Unknown Object (File)
	Wed, Jan 22, 6:43 PM

	Unknown Object (File)
	Mon, Jan 20, 11:56 AM

	Unknown Object (File)
	Mon, Jan 20, 11:56 AM

	Unknown Object (File)
	Mon, Jan 20, 11:56 AM

	Unknown Object (File)
	Mon, Jan 20, 11:56 AM

	Unknown Object (File)
	Mon, Jan 20, 9:40 AM

View All 53 Files

Subscribers

None

Details

Reviewers

jhb

Commits

rGc56de177d282: x86: initialize initial FPU state earlier

Summary

Make it under SI_SUB_CPU sysinit, instead of much later SI_SUB_DRIVERS. The SI_SUB_DRIVERS survived from times when FPU used real ISA attachment, now it is only pnp stub claiming id.

PR: 255997

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kib requested review of this revision.May 27 2021, 4:37 PM

kib created this revision.

jhb added inline comments.May 27 2021, 9:57 PM

sys/amd64/amd64/fpu.c
498	Can this be SI_ORDER_ANY? I can't recall if there is a specific order to the SI_SUB_CPU inits.

Use SI_ORDER_ANY on amd64, same as on i386.

jhb accepted this revision.May 28 2021, 5:49 PM

This revision is now accepted and ready to land.May 28 2021, 5:49 PM

Closed by commit rGc56de177d282: x86: initialize initial FPU state earlier (authored by kib). · Explain WhyMay 28 2021, 6:39 PM

This revision was automatically updated to reflect the committed changes.

kib added a commit: rGc56de177d282: x86: initialize initial FPU state earlier.

Revision Contents
Changeset List

Path

Size

sys/

amd64/

fpu.c

2 lines

i386/

npx.c

2 lines

Diff 90073

View Options

sys/amd64/amd64/fpu.c