Page MenuHomeFreeBSD
Differential D30512

x86: initialize initial FPU state earlier
ClosedPublic
Actions

Authored by kib on May 27 2021, 4:37 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Mar 30, 10:38 PM
Unknown Object (File)
Feb 22 2025, 10:34 PM
Unknown Object (File)
Feb 21 2025, 7:36 PM
Unknown Object (File)
Jan 30 2025, 12:26 PM
Unknown Object (File)
Jan 30 2025, 12:12 PM
Unknown Object (File)
Jan 29 2025, 4:43 AM
Unknown Object (File)
Jan 29 2025, 2:21 AM
Unknown Object (File)
Jan 22 2025, 6:43 PM
View All 58 Files
Subscribers
None

Details

Reviewers
jhb
Commits
rGc56de177d282: x86: initialize initial FPU state earlier
Summary

Make it under SI_SUB_CPU sysinit, instead of much later SI_SUB_DRIVERS. The SI_SUB_DRIVERS survived from times when FPU used real ISA attachment, now it is only pnp stub claiming id.

PR: 255997

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

kib requested review of this revision.May 27 2021, 4:37 PM
kib created this revision.
jhb added inline comments.May 27 2021, 9:57 PM
sys/amd64/amd64/fpu.c
498

Can this be SI_ORDER_ANY? I can't recall if there is a specific order to the SI_SUB_CPU inits.

kib updated this revision to Diff 90032.May 27 2021, 10:44 PM
kib marked an inline comment as done.

Use SI_ORDER_ANY on amd64, same as on i386.

jhb accepted this revision.May 28 2021, 5:49 PM
This revision is now accepted and ready to land.May 28 2021, 5:49 PM
Closed by commit rGc56de177d282: x86: initialize initial FPU state earlier (authored by kib). · Explain WhyMay 28 2021, 6:39 PM
This revision was automatically updated to reflect the committed changes.
kib added a commit: rGc56de177d282: x86: initialize initial FPU state earlier.

Revision Contents
Changeset List

PathSize
sys/
amd64/
amd64/
2 lines
i386/
i386/
2 lines

Diff 90073

View Options

sys/amd64/amd64/fpu.c

Show First 20 Lines • Show All 82 Lines • ▼ Show 20 Linescap_openlog(cap_channel_t *chan, const char *ident, int logopt, int facility)
nvl = nvlist_create(0); nvl = nvlist_create(0);
nvlist_add_string(nvl, "cmd", "openlog"); nvlist_add_string(nvl, "cmd", "openlog");
if (ident != NULL) { if (ident != NULL) {
nvlist_add_string(nvl, "ident", ident); nvlist_add_string(nvl, "ident", ident);
} }
nvlist_add_number(nvl, "logopt", logopt); nvlist_add_number(nvl, "logopt", logopt);
nvlist_add_number(nvl, "facility", facility); nvlist_add_number(nvl, "facility", facility);
if (logopt & LOG_PERROR) {
nvlist_add_descriptor(nvl, "stderr", STDERR_FILENO);
}
nvl = cap_xfer_nvlist(chan, nvl); nvl = cap_xfer_nvlist(chan, nvl);
if (nvl == NULL) { if (nvl == NULL) {
return; return;
} }
nvlist_destroy(nvl); nvlist_destroy(nvl);
} }
void void
Show All 27 Linescap_setlogmask(cap_channel_t *chan, int maskpri)
return (omask); return (omask);
} }
/* /*
* Service functions. * Service functions.
*/ */
static char *LogTag; static char *LogTag;
static int prev_stderr = -1;
static void static void
slog_vsyslog(const nvlist_t *limits __unused, const nvlist_t *nvlin, slog_vsyslog(const nvlist_t *limits __unused, const nvlist_t *nvlin,
nvlist_t *nvlout __unused) nvlist_t *nvlout __unused)
{ {
syslog(nvlist_get_number(nvlin, "priority"), "%s", syslog(nvlist_get_number(nvlin, "priority"), "%s",
nvlist_get_string(nvlin, "message")); nvlist_get_string(nvlin, "message"));
} }
static void static void
slog_openlog(const nvlist_t *limits __unused, const nvlist_t *nvlin, slog_openlog(const nvlist_t *limits __unused, const nvlist_t *nvlin,
nvlist_t *nvlout __unused) nvlist_t *nvlout __unused)
{ {
const char *ident; const char *ident;
uint64_t logopt;
int stderr_fd;
ident = dnvlist_get_string(nvlin, "ident", NULL); ident = dnvlist_get_string(nvlin, "ident", NULL);
if (ident != NULL) { if (ident != NULL) {
free(LogTag); free(LogTag);
LogTag = strdup(ident); LogTag = strdup(ident);
} }
openlog(LogTag, nvlist_get_number(nvlin, "logopt"), logopt = nvlist_get_number(nvlin, "logopt");
nvlist_get_number(nvlin, "facility")); if (logopt & LOG_PERROR) {
stderr_fd = dnvlist_get_descriptor(nvlin, "stderr", -1);
if (prev_stderr == -1)
prev_stderr = dup(STDERR_FILENO);
if (prev_stderr != -1)
(void)dup2(stderr_fd, STDERR_FILENO);
} else if (prev_stderr != -1) {
(void)dup2(prev_stderr, STDERR_FILENO);
close(prev_stderr);
prev_stderr = -1;
} }
openlog(LogTag, logopt, nvlist_get_number(nvlin, "facility"));
}
static void static void
slog_closelog(const nvlist_t *limits __unused, const nvlist_t *nvlin __unused, slog_closelog(const nvlist_t *limits __unused, const nvlist_t *nvlin __unused,
nvlist_t *nvlout __unused) nvlist_t *nvlout __unused)
{ {
closelog(); closelog();
free(LogTag); free(LogTag);
LogTag = NULL; LogTag = NULL;
if (prev_stderr != -1) {
(void)dup2(prev_stderr, STDERR_FILENO);
close(prev_stderr);
prev_stderr = -1;
} }
}
static void static void
slog_setlogmask(const nvlist_t *limits __unused, const nvlist_t *nvlin, slog_setlogmask(const nvlist_t *limits __unused, const nvlist_t *nvlin,
nvlist_t *nvlout) nvlist_t *nvlout)
{ {
int omask; int omask;
omask = setlogmask(nvlist_get_number(nvlin, "maskpri")); omask = setlogmask(nvlist_get_number(nvlin, "maskpri"));
Show All 15 Lines if (strcmp(cmd, "vsyslog") == 0) {
slog_setlogmask(limits, nvlin, nvlout); slog_setlogmask(limits, nvlin, nvlout);
} else { } else {
return (EINVAL); return (EINVAL);
} }
return (0); return (0);
} }
CREATE_SERVICE("system.syslog", NULL, syslog_command, CASPER_SERVICE_STDIO); CREATE_SERVICE("system.syslog", NULL, syslog_command, 0);
View Options

sys/i386/i386/npx.c

Show First 20 Lines • Show All 82 Lines • ▼ Show 20 Linescap_openlog(cap_channel_t *chan, const char *ident, int logopt, int facility)
nvl = nvlist_create(0); nvl = nvlist_create(0);
nvlist_add_string(nvl, "cmd", "openlog"); nvlist_add_string(nvl, "cmd", "openlog");
if (ident != NULL) { if (ident != NULL) {
nvlist_add_string(nvl, "ident", ident); nvlist_add_string(nvl, "ident", ident);
} }
nvlist_add_number(nvl, "logopt", logopt); nvlist_add_number(nvl, "logopt", logopt);
nvlist_add_number(nvl, "facility", facility); nvlist_add_number(nvl, "facility", facility);
if (logopt & LOG_PERROR) {
nvlist_add_descriptor(nvl, "stderr", STDERR_FILENO);
}
nvl = cap_xfer_nvlist(chan, nvl); nvl = cap_xfer_nvlist(chan, nvl);
if (nvl == NULL) { if (nvl == NULL) {
return; return;
} }
nvlist_destroy(nvl); nvlist_destroy(nvl);
} }
void void
Show All 27 Linescap_setlogmask(cap_channel_t *chan, int maskpri)
return (omask); return (omask);
} }
/* /*
* Service functions. * Service functions.
*/ */
static char *LogTag; static char *LogTag;
static int prev_stderr = -1;
static void static void
slog_vsyslog(const nvlist_t *limits __unused, const nvlist_t *nvlin, slog_vsyslog(const nvlist_t *limits __unused, const nvlist_t *nvlin,
nvlist_t *nvlout __unused) nvlist_t *nvlout __unused)
{ {
syslog(nvlist_get_number(nvlin, "priority"), "%s", syslog(nvlist_get_number(nvlin, "priority"), "%s",
nvlist_get_string(nvlin, "message")); nvlist_get_string(nvlin, "message"));
} }
static void static void
slog_openlog(const nvlist_t *limits __unused, const nvlist_t *nvlin, slog_openlog(const nvlist_t *limits __unused, const nvlist_t *nvlin,
nvlist_t *nvlout __unused) nvlist_t *nvlout __unused)
{ {
const char *ident; const char *ident;
uint64_t logopt;
int stderr_fd;
ident = dnvlist_get_string(nvlin, "ident", NULL); ident = dnvlist_get_string(nvlin, "ident", NULL);
if (ident != NULL) { if (ident != NULL) {
free(LogTag); free(LogTag);
LogTag = strdup(ident); LogTag = strdup(ident);
} }
openlog(LogTag, nvlist_get_number(nvlin, "logopt"), logopt = nvlist_get_number(nvlin, "logopt");
nvlist_get_number(nvlin, "facility")); if (logopt & LOG_PERROR) {
stderr_fd = dnvlist_get_descriptor(nvlin, "stderr", -1);
if (prev_stderr == -1)
prev_stderr = dup(STDERR_FILENO);
if (prev_stderr != -1)
(void)dup2(stderr_fd, STDERR_FILENO);
} else if (prev_stderr != -1) {
(void)dup2(prev_stderr, STDERR_FILENO);
close(prev_stderr);
prev_stderr = -1;
} }
openlog(LogTag, logopt, nvlist_get_number(nvlin, "facility"));
}
static void static void
slog_closelog(const nvlist_t *limits __unused, const nvlist_t *nvlin __unused, slog_closelog(const nvlist_t *limits __unused, const nvlist_t *nvlin __unused,
nvlist_t *nvlout __unused) nvlist_t *nvlout __unused)
{ {
closelog(); closelog();
free(LogTag); free(LogTag);
LogTag = NULL; LogTag = NULL;
if (prev_stderr != -1) {
(void)dup2(prev_stderr, STDERR_FILENO);
close(prev_stderr);
prev_stderr = -1;
} }
}
static void static void
slog_setlogmask(const nvlist_t *limits __unused, const nvlist_t *nvlin, slog_setlogmask(const nvlist_t *limits __unused, const nvlist_t *nvlin,
nvlist_t *nvlout) nvlist_t *nvlout)
{ {
int omask; int omask;
omask = setlogmask(nvlist_get_number(nvlin, "maskpri")); omask = setlogmask(nvlist_get_number(nvlin, "maskpri"));
Show All 15 Lines if (strcmp(cmd, "vsyslog") == 0) {
slog_setlogmask(limits, nvlin, nvlout); slog_setlogmask(limits, nvlin, nvlout);
} else { } else {
return (EINVAL); return (EINVAL);
} }
return (0); return (0);
} }
CREATE_SERVICE("system.syslog", NULL, syslog_command, CASPER_SERVICE_STDIO); CREATE_SERVICE("system.syslog", NULL, syslog_command, 0);