ktrace: Remove vrele() at the end of ktr_writerequest()
ClosedPublic
Actions

Authored by markj on May 23 2021, 5:24 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Mon, May 11, 10:36 PM

	Unknown Object (File)
	Mon, May 11, 10:36 PM

	Unknown Object (File)
	Mon, May 11, 9:43 PM

	Unknown Object (File)
	May 8 2026, 7:08 PM

	Unknown Object (File)
	May 1 2026, 11:52 PM

	Unknown Object (File)
	Apr 30 2026, 1:19 PM

	Unknown Object (File)
	Apr 29 2026, 8:41 AM

	Unknown Object (File)
	Apr 28 2026, 6:56 PM

View All Files

Subscribers

imp

Details

Reviewers

kib

Commits

rG6f6cd1e8e8aa: ktrace: Remove vrele() at the end of ktr_writerequest()

Summary

As of commit fc369a353 we no longer ref the vnode when writing a record.
Drop the corresponding vrele() call in the error case.

Fixes: fc369a353 ("ktrace: fix a race between writes and close")
Reported by: syzbot+9b96ea7a5ff8917d3fe4@syzkaller.appspotmail.com
Reported by: syzbot+6120ebbb354cd52e5107@syzkaller.appspotmail.com
MFC after: 6 days

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

markj created this revision.May 23 2021, 5:24 PM

Herald added a subscriber: imp. · View Herald TranscriptMay 23 2021, 5:24 PM

markj requested review of this revision.May 23 2021, 5:24 PM

Harbormaster completed remote builds in B39361: Diff 89693.May 23 2021, 5:24 PM

kib accepted this revision.May 23 2021, 5:42 PM

This revision is now accepted and ready to land.May 23 2021, 5:42 PM

Closed by commit rG6f6cd1e8e8aa: ktrace: Remove vrele() at the end of ktr_writerequest() (authored by markj). · Explain WhyMay 23 2021, 6:14 PM

This revision was automatically updated to reflect the committed changes.

markj added a commit: rG6f6cd1e8e8aa: ktrace: Remove vrele() at the end of ktr_writerequest().

Revision Contents
Changeset List

Path

Size

sys/

kern/

kern_ktrace.c

1 line

Diff 89696

View Options

ktrace: Remove vrele() at the end of ktr_writerequest()ClosedPublicActions