Page MenuHomeFreeBSD

Fix LLD_LINK descriptions
ClosedPublic

Authored by dim on May 22 2021, 11:02 AM.
Tags
None
Referenced Files
Unknown Object (File)
Dec 30 2023, 3:39 PM
Unknown Object (File)
Dec 24 2023, 4:44 PM
Unknown Object (File)
May 15 2023, 5:19 AM
Unknown Object (File)
Apr 26 2023, 4:10 AM
Unknown Object (File)
Dec 23 2022, 3:41 PM
Subscribers

Details

Reviewers
brooks
Summary

Currently, the LLD_LINK option is described as "Link ld.lld as ld to
clang uses it". I'm not a native English speaker, but this seems like a
typo. Probably "so" instead of "to" was meant? I also propose to add a
comma, to make it a little clearer.

That said, for e.g. llvm11 and 12, I don't really see how the option is
actually implemented, so maybe it can be ditched anyway? For llvm90,
there is a fragment in the Makefile that has:

post-install-LLD_LINK-on:
	${LN} -s ld.lld ${STAGEDIR}${LLVM_PREFIX}/bin/ld

but I see no such thing for the later llvm ports.

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 39356
Build 36245: arc lint + arc unit

Event Timeline

dim requested review of this revision.May 22 2021, 11:02 AM

Thanks for the better wording. As you noticed, LLD_LINK doesn't do anything in llvm10 and later (the link is made unconditionally). I think I'd like to go ahead and commit the change to llvm90 immediately because I don't think it will trigger rebuilds, but check that there aren't other changes I should be making to 11-12 before deleting the options since that definitely triggers a rebuild in poudriere.

Sigh, I committed the changes and had pasted in the wrong review url. Accepting so I can close...

This revision is now accepted and ready to land.Jul 16 2021, 6:16 PM