axgbe: Don't dereference NULL pointers
ClosedPublic
Actions

Authored by imp on May 21 2021, 4:51 AM.

Tags

None

Referenced Files

	F137592141: D30373.id89568.diff
	Mon, Nov 24, 12:14 PM

	F137592140: D30373.id.diff
	Mon, Nov 24, 12:14 PM

	F137592138: D30373.id90371.diff
	Mon, Nov 24, 12:14 PM

	F137592057: D30373.diff
	Mon, Nov 24, 12:13 PM

	F137554809: D30373.diff
	Mon, Nov 24, 7:22 AM

	Unknown Object (File)
	Wed, Nov 12, 11:27 AM

	Unknown Object (File)
	Mon, Nov 10, 12:01 AM

	Unknown Object (File)
	Thu, Nov 6, 5:43 AM

View All 79 Files

Subscribers

allanjude

Details

Reviewers

manu
rajeshasp
allanjude

Commits

rGce0a9d7c126f: axgbe: Don't dereference NULL pointers

Summary

if (sb == NULL) { ... sb->s_error } is going to be a bad time. Return
ENOMEM when we cannot allocate an sbuf for the sysctl rather than
dereferencing the NULL pointer just returned.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

imp requested review of this revision.May 21 2021, 4:51 AM

imp created this revision.

Harbormaster completed remote builds in B39332: Diff 89568.May 21 2021, 4:51 AM

imp added a reviewer: manu.May 21 2021, 4:05 PM

imp added a reviewer: rajeshasp.May 21 2021, 4:09 PM

manu accepted this revision.May 21 2021, 4:09 PM

This revision is now accepted and ready to land.May 21 2021, 4:09 PM

Reviewed By: allanjude

Closed by commit rGce0a9d7c126f: axgbe: Don't dereference NULL pointers (authored by imp). · Explain WhyJun 3 2021, 6:04 PM

This revision was automatically updated to reflect the committed changes.

imp added a commit: rGce0a9d7c126f: axgbe: Don't dereference NULL pointers.

Revision Contents
Changeset List

Path

Size

sys/

dev/

axgbe/

xgbe-sysctl.c

38 lines

Diff 90371

View Options

sys/dev/axgbe/xgbe-sysctl.c

axgbe: Don't dereference NULL pointersClosedPublicActions