Page MenuHomeFreeBSD
Differential D3036

PR# 201371: Properly initialize variable
ClosedPublic
Actions

Authored by eri on Jul 9 2015, 12:10 PM.
Tags
Referenced Files
Unknown Object (File)
Jan 31 2024, 12:39 AM
Unknown Object (File)
Jan 9 2024, 3:07 AM
Unknown Object (File)
Jan 9 2024, 3:06 AM
Unknown Object (File)
Jan 9 2024, 3:06 AM
Unknown Object (File)
Jan 9 2024, 2:50 AM
Unknown Object (File)
Dec 8 2023, 8:24 PM
Unknown Object (File)
Nov 23 2023, 2:52 PM
Unknown Object (File)
Nov 23 2023, 11:26 AM
View All 81 Files
Subscribers
imp
network

Details

Reviewers
gnn
Commits
rS286026: MFC 285325
rS285325: Correct issue presented in r285051,
Summary

Apparently neither clang nor gcc complain about this.
But clang intis the var to NULL correctly while gcc on at least mips does not.
Correct the undefined behavior by initializing the variable properly.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

eri updated this revision to Diff 6816.Jul 9 2015, 12:10 PM
eri retitled this revision from to PR# 201371: Properly initialize variable.
eri updated this object.
eri edited the test plan for this revision. (Show Details)
eri added a reviewer: gnn.
eri set the repository for this revision to rS FreeBSD src repository - subversion.
eri added a project: network.
eri added a subscriber: network.
Herald added a subscriber: imp. · View Herald TranscriptJul 9 2015, 12:10 PM
eri added a comment.Jul 9 2015, 3:53 PM

Confirmed this fixes the issue from PR reporter.

gnn accepted this revision.Jul 9 2015, 4:14 PM
gnn edited edge metadata.
This revision is now accepted and ready to land.Jul 9 2015, 4:14 PM
Closed by commit rS285325: Correct issue presented in r285051, (authored by eri). · Explain WhyJul 9 2015, 4:28 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
head/
sys/
netinet/
3 lines

Diff 6825

View Options

head/sys/netinet/ip_input.c

Loading...