Fix intr_machdep.c for armv8
ClosedPublic
Actions

Authored by wma_semihalf.com on Jul 9 2015, 5:33 AM.

Details

Reviewers

zbb
emaste
andrew

Commits

rS285533: Fix intr_machdep.c for ARM64

Summary

On armv8 IPIs are mapped to 0-15. Incrementing the number by 16 is wrong, because it sets a reserved bit in the IPI register. This patch removes all "+16" to comply with specs.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

wma_semihalf.com updated this revision to Diff 6801.Jul 9 2015, 5:33 AM

wma_semihalf.com retitled this revision from to Fix intr_machdep.c for armv8.

wma_semihalf.com updated this object.

wma_semihalf.com edited the test plan for this revision. (Show Details)

wma_semihalf.com added reviewers: andrew, emaste, zbb.

wma_semihalf.com set the repository for this revision to rS FreeBSD src repository - subversion.

Herald added subscribers: emaste, andrew, imp. · View Herald TranscriptJul 9 2015, 5:33 AM

andrew added inline comments.Jul 12 2015, 10:56 AM

sys/arm64/arm64/intr_machdep.c
450 ↗	(On Diff #6801)	Why has this been added? I's unrelated to the rest of the patch.

wma_semihalf.com added inline comments.Jul 12 2015, 4:11 PM

sys/arm64/arm64/intr_machdep.c
450 ↗	(On Diff #6801)	It's just a cleanup here. We'll need this function in the near future, so I added it into this patch and use inside arm_unmask_ipi, just not to touch this file again.

andrew added inline comments.Jul 13 2015, 9:59 AM

sys/arm64/arm64/intr_machdep.c
450 ↗	(On Diff #6801)	Can you move this part of the change to that review then? I need to think about D3034 a little, but have no problems with the rest of this change.

Closed by commit rS285533: Fix intr_machdep.c for ARM64 (authored by zbb). · Explain WhyJul 14 2015, 11:59 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

head/

sys/

arm64/

intr_machdep.c

12 lines

Diff 6916

View Options

head/sys/arm64/arm64/intr_machdep.c

Fix intr_machdep.c for armv8ClosedPublicActions