ACPI driver requires special functions to be provided by machdep code.
Add temporary stubs to satisfy the compiler when both "pci" and "acpi" are enabled.
Details
Details
- Reviewers
zbb emaste andrew - Commits
- rS285421: Implement stubs for ACPI PCI routines
Diff Detail
Diff Detail
- Repository
- rS FreeBSD src repository - subversion
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
| sys/arm64/arm64/pci_cfgreg.c | ||
|---|---|---|
| 1 ↗ | (On Diff #6800) | This file should be in sys/arm64/acpica, it's only needed by the acpi code. |
| sys/arm64/include/pci_cfgreg.h | ||
| 1 ↗ | (On Diff #6800) | What is the license of this file? |
| 3–4 ↗ | (On Diff #6800) | This should be: #ifndef _MACHINE_PCI_CFGREG_H #define<tab>_MACHINE_PCI_CFGREG_H |
| 7 ↗ | (On Diff #6800) | We don't normally put the argument names here, it would notmally be something like: uint32_t pci_cfgregread(int, int, int, int, int); |
| sys/conf/files.arm64 | ||
| 39 ↗ | (On Diff #6800) | As the file isn't needed with fdt you can check for both pci and acpi here. |
| sys/arm64/acpica/pci_cfgreg.c | ||
|---|---|---|
| 50 ↗ | (On Diff #6810) | Add ARM64TODO in comment (or in the panic string itself) for ease of grep -r (and in the other spots) No need to re-upload for just this change though |
Comment Actions
Any other issues except ARM64TOFO? If not, please accept this revision, I'd like to submit it soon.