Page MenuHomeFreeBSD

storvsc: fix auto-sense reporting
ClosedPublic

Authored by avg on May 5 2021, 2:14 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Nov 18, 11:32 AM
Unknown Object (File)
Sun, Nov 17, 8:50 PM
Unknown Object (File)
Sun, Nov 10, 10:35 AM
Unknown Object (File)
Sun, Nov 10, 6:49 AM
Unknown Object (File)
Sat, Nov 9, 11:19 PM
Unknown Object (File)
Oct 18 2024, 7:55 AM
Unknown Object (File)
Oct 18 2024, 6:52 AM
Unknown Object (File)
Oct 15 2024, 6:41 PM
Subscribers

Details

Summary

I saw a situation where the driver set CAM_AUTOSNS_VALID on a failed ccb
even though SRB_STATUS_AUTOSENSE_VALID was not set in the status.
The actual sense data remained all zeros.
The problem seems to be that create_storvsc_request() always sets
hv_storvsc_request::sense_info_len, so checking for sense_info_len != 0
is not enough to determine if any auto-sense data is actually available.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

avg requested review of this revision.May 5 2021, 2:14 PM

The cam part of this looks good. Don't know if that's the right bit to test, but it sure sounds like it

This revision is now accepted and ready to land.May 5 2021, 2:41 PM

Thanks for fixing this.

This revision was automatically updated to reflect the committed changes.