devfs: Avoid comparison with an uninitialized var in devfs_fp_check()
ClosedPublic
Actions

Authored by markj on May 1 2021, 2:19 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Mon, Mar 30, 6:06 AM

	Unknown Object (File)
	Thu, Mar 26, 5:59 PM

	Unknown Object (File)
	Mon, Mar 23, 3:16 PM

	Unknown Object (File)
	Sun, Mar 22, 10:38 AM

	Unknown Object (File)
	Tue, Mar 17, 5:12 AM

	Unknown Object (File)
	Tue, Mar 17, 5:03 AM

	Unknown Object (File)
	Mon, Mar 9, 1:42 PM

	Unknown Object (File)
	Mon, Mar 9, 1:42 PM

View All Files

Subscribers

imp

Details

Reviewers

kib

Commits

rG243b324f9668: devfs: Avoid comparison with an uninitialized var in devfs_fp_check()

Summary

devvn_refthread() will initialize *devp only if it suceeds, so check for
success before comparing with fp->f_data. Other devfs_fp_check()
callers are careful to do this.

Reported by: KMSAN

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

markj created this revision.May 1 2021, 2:19 PM

Herald added a subscriber: imp. · View Herald TranscriptMay 1 2021, 2:19 PM

markj requested review of this revision.May 1 2021, 2:19 PM

Harbormaster completed remote builds in B38954: Diff 88470.May 1 2021, 2:19 PM

markj added a reviewer: kib.May 1 2021, 2:19 PM

You mean, '... other devvn_refthread() callers are careful ...'

This revision is now accepted and ready to land.May 1 2021, 3:04 PM

Closed by commit rG243b324f9668: devfs: Avoid comparison with an uninitialized var in devfs_fp_check() (authored by markj). · Explain WhyMay 3 2021, 5:56 PM

This revision was automatically updated to reflect the committed changes.

markj added a commit: rG243b324f9668: devfs: Avoid comparison with an uninitialized var in devfs_fp_check().

Revision Contents
Changeset List

Path

Size

sys/

fs/

devfs/

devfs_vnops.c

3 lines

Diff 88564

View Options

sys/fs/devfs/devfs_vnops.c

devfs: Avoid comparison with an uninitialized var in devfs_fp_check()ClosedPublicActions