Page MenuHomeFreeBSD

[new port] devel/py-pytest-cache
ClosedPublic

Authored by loader on Jul 5 2015, 11:56 AM.

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

loader retitled this revision from to [new port] devel/py-pytest-cache.
loader updated this object.
loader edited the test plan for this revision. (Show Details)
loader added a reviewer: koobs.

Hi Kubilay,

It took a very long time to run arc diff --create, just got your message on Bugzilla.
I will upload another patch.

Thanks.

koobs added a subscriber: eadler.

I've been seeing delays interacting from CLi -> phabricator too. I see connect(2) timeouts, mostly on the IPV6 address. Are you configured for IPV6 too? cc @eadler

loader edited edge metadata.
  • changed RUN_DEPENDS version of sysutiles/py-execnet to 1.2 (current version in the ports tree)
  • added a regression-test: target

I have no IPv6, my problem looks like a filesystem issue.
I ran the update command in the ~/ports/devel/py-pytest-cache directory,
then "svn --xml status ." kept running for about 2 hours.

% arc diff --update D2996 .
load: 0.34 cmd: svnlite 81711 [zio->io_cv] 6617.44r 26.95u 66.65s 0% 15312k

Also tried to run "svnlite status" on the UFS, it only takes 58 seconds.

Thanks.

koobs requested changes to this revision.EditedJul 5 2015, 3:44 PM
koobs edited edge metadata.

@loader Nice work on the regression-test :)

Can you add the following:

TEST_DEPENDS= ${PYTHON_PKGNAMEPREFIX}pytest>0:${PORTSDIR}/devel/py-pytest

While they're not automatically used by the framework (yet), they are handy for maintainers and users alike.

Also, rather than 'extract', I default to using:

regression-test: build

unless there's a particular reason not to build first. this will ensure that all dependencies are satisfied first, rather than being downloaded automatically by setuptools

Bonus Points (Optional: not necessary for this review unless you want to)

For some ports, I add the following:

OPTIONS_DEFINE=      TESTS
TESTS_DESC=          Install test suite requirements
TESTS_BUILD_DEPENDS= ${TEST_DEPENDS}

Gold Star Points (Optional: not necessary for this review unless you want to)

Add 'test' command support to run py.test by patching setup.py See:

https://pytest.org/latest/goodpractises.html#integration-with-setuptools-test-commands

With the above change, the regression-test: invocation can be set to the 'canonical'

cd ${WRKSRC} && ${PYTHON_CMD} ${PYDISTUTILS_SETUP} test
This revision now requires changes to proceed.Jul 5 2015, 3:44 PM

sorry, missed devel/Makefile. I will move to UFS and run it again.

loader edited edge metadata.

Thanks @koobs for the tips, they are really helpful. :)

koobs edited edge metadata.

My pleasure :)

Your change looks super, if it still passes portlint and poudriere, ship it! :)

Just a reminder, commit message should include Approved by, Differential Revision: <full URL> and PR: references, like:

[NEW] cat/port: COMMENT

<pkg-descr>

PR: 199774
Approved by: koobs
Differential Revision: https://reviews.freebsd.org/D2996

Feel free to include a Proposed commit log in the Summary section of any future revisions you create here

This revision is now accepted and ready to land.Jul 5 2015, 5:02 PM
This revision was automatically updated to reflect the committed changes.