Page MenuHomeFreeBSD
Differential D29929

Fix inode birthtime updating.
ClosedPublic
Actions

Authored by fsu on Apr 22 2021, 5:25 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, May 10, 11:15 PM
Unknown Object (File)
Thu, May 9, 7:47 PM
Unknown Object (File)
Wed, May 1, 7:03 PM
Unknown Object (File)
Sat, Apr 27, 4:12 AM
Unknown Object (File)
Fri, Apr 26, 4:40 PM
Unknown Object (File)
Thu, Apr 25, 5:09 PM
Unknown Object (File)
Sat, Apr 20, 1:04 AM
Unknown Object (File)
Thu, Apr 18, 2:54 PM
View All 55 Files
Subscribers
None

Details

Reviewers
pfg
Commits
rG1484574843a3: Fix inode birthtime updating logic.
Summary

The birthtime field of struct vattr does not checked for VNOVAL in case of ext2_setattr() and produce incorrect inode birthtime values.

Test Plan

Found using pjdfstest: pjdfstest/tests/utimensat/03.t.
Testcase passed after fix.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

fsu requested review of this revision.Apr 22 2021, 5:25 PM
fsu created this revision.
pfg accepted this revision.Apr 22 2021, 8:05 PM

Minor knits, otherwise LGTM.

sys/fs/ext2fs/ext2_vnops.c
380

Not needed because the macro has parenthesis already (standard practice).

509

Invert the order: whe should verify if E2DI_AS_XTIME first and only then check for VNOVAL.

This revision is now accepted and ready to land.Apr 22 2021, 8:05 PM
fsu updated this revision to Diff 88043.Apr 23 2021, 2:32 PM

Fix and expression order.

This revision now requires review to proceed.Apr 23 2021, 2:32 PM
fsu added inline comments.Apr 23 2021, 2:33 PM
sys/fs/ext2fs/ext2_vnops.c
380

May be let's leave it as is. The concern is, that if expression without braces looks strange. Also, we have same if expressions with braces in the ext2_inode_cnv.c.

pfg accepted this revision.Apr 23 2021, 4:04 PM
This revision is now accepted and ready to land.Apr 23 2021, 4:04 PM
Closed by commit rG1484574843a3: Fix inode birthtime updating logic. (authored by fsu). · Explain WhyMay 7 2021, 7:10 AM
This revision was automatically updated to reflect the committed changes.
fsu marked an inline comment as not done.
fsu added a commit: rG1484574843a3: Fix inode birthtime updating logic..

Revision Contents
Changeset List

PathSize
sys/
fs/
ext2fs/
8 lines

Diff 87990

View Options

sys/fs/ext2fs/ext2_vnops.c

Loading...