Differential D29802

New port: textproc/gi-docgen: Documentation generator for GObject-based libraries
ClosedPublic
Actions

Authored by nc on Apr 17 2021, 5:00 AM.

Tags

Referenced Files

	Unknown Object (File)
	Tue, Apr 16, 10:13 PM

	Unknown Object (File)
	Tue, Apr 16, 4:52 PM

	Unknown Object (File)
	Tue, Apr 16, 3:53 PM

	Unknown Object (File)
	Tue, Apr 16, 3:45 PM

	Unknown Object (File)
	Tue, Apr 16, 3:30 PM

	Unknown Object (File)
	Tue, Apr 16, 3:30 PM

	Unknown Object (File)
	Tue, Apr 16, 3:27 PM

	Unknown Object (File)
	Tue, Apr 16, 1:34 PM

View All 59 Files

Subscribers

Details

Reviewers

Group Reviewers

gnome
desktop

Commits

R11:e59acf0cf772: textproc/gi-docgen: Add port: Documentation generator for GObject-based…

Summary

New port: textproc/gi-docgen: Documentation generator for GObject-based libraries

Needed for D29794.

Test Plan

Passes poudriere and portclippy

Diff Detail

Repository

R11 FreeBSD ports repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

nc created this revision.Apr 17 2021, 5:00 AM

Herald added a subscriber: mat. · View Herald TranscriptApr 17 2021, 5:00 AM

nc requested review of this revision.Apr 17 2021, 5:00 AM

Harbormaster completed remote builds in B38636: Diff 87600.Apr 17 2021, 5:00 AM

nc added reviewers: gnome, desktop.Apr 17 2021, 5:01 AM

nc added projects: desktop, gnome.

nc added subscribers: gnome, desktop.

Remove erroneous newline at end of Makefile.

Harbormaster completed remote builds in B38637: Diff 87601.Apr 17 2021, 5:02 AM

nc mentioned this in D29794: Update x11-toolkits/pango to 1.48.4.Apr 17 2021, 5:03 AM

share/pkgconfig/gi-docgen.pc doesn't work. We need to use libexec/pkgconfig/gi-docgen.pc.

We should store the pc file in the correct location.

Harbormaster completed remote builds in B38638: Diff 87602.Apr 17 2021, 5:41 AM

nc mentioned this in D29803: textproc/py-markdown: Update to 3.3.4.Apr 17 2021, 5:46 AM

diizzy added a subscriber: diizzy.Apr 17 2021, 5:56 AM

diizzy added inline comments.

textproc/gi-docgen/Makefile
21	This seems incomplete? https://gitlab.gnome.org/ebassi/gi-docgen/-/blob/main/setup.cfg#L46 (setuptools and wheel)

tcberner requested changes to this revision.Apr 17 2021, 7:44 AM

tcberner added a subscriber: tcberner.

tcberner added inline comments.

textproc/gi-docgen/Makefile
22	^don't do that [tm] -- you're adding meson & ninja as a runtime dep. see: https://docs.freebsd.org/en/books/porters-handbook/makefiles/#makefile-depend

This revision now requires changes to proceed.Apr 17 2021, 7:44 AM

Don't set RUN_DEPENDS to BUILD_DEPENDS.

Harbormaster completed remote builds in B38649: Diff 87620.Apr 17 2021, 4:07 PM

Depend on textproc/py-markdown3

Harbormaster completed remote builds in B38724: Diff 87809.Apr 20 2021, 3:24 PM

textproc/py-markdown3 wasn't detected by meson, reverting

Harbormaster completed remote builds in B38729: Diff 87817.Apr 20 2021, 4:17 PM

This patch/new port is ready for a review, since the py-markdown update has finally been committed.

This revision was not accepted when it landed; it landed in state Needs Review.May 24 2021, 7:14 PM

Closed by commit R11:e59acf0cf772: textproc/gi-docgen: Add port: Documentation generator for GObject-based… (authored by nc). · Explain Why

This revision was automatically updated to reflect the committed changes.

nc added a commit: R11:e59acf0cf772: textproc/gi-docgen: Add port: Documentation generator for GObject-based….

Revision Contents
Changeset List

Path

Size

textproc/

1 line

gi-docgen/

30 lines

3 lines

files/

patch-meson.build

11 lines

6 lines

73 lines

Diff 89768

textproc/Makefile

Loading...

textproc/gi-docgen/Makefile

Loading...

textproc/gi-docgen/distinfo

Loading...

textproc/gi-docgen/files/patch-meson.build

Loading...

textproc/gi-docgen/pkg-descr

Loading...

textproc/gi-docgen/pkg-plist

Loading...