iscsi: Kick threads out of iscsi_ioctl() during unload.
ClosedPublic
Actions

Authored by jhb on Apr 10 2021, 12:00 AM.

Details

Reviewers

Commits

rG89df484739ef: iscsi: Kick threads out of iscsi_ioctl() during unload.

Summary

iscsid can be sleeping in iscsi_ioctl() causing the destroy_dev() to
sleep forever if iscsi.ko is unloaded while iscsid is running.

Reported by: Jithesh Arakkan @ Chelsio
MFC after: 1 week
Sponsored by: Chelsio Communications

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

jhb created this revision.Apr 10 2021, 12:00 AM

Herald added a subscriber: imp. · View Herald TranscriptApr 10 2021, 12:00 AM

jhb requested review of this revision.Apr 10 2021, 12:00 AM

Harbormaster completed remote builds in B38476: Diff 87165.Apr 10 2021, 12:00 AM

To reproduce, just kldunload iscsi while iscsid is running. The kldunload will hang in "devdrn" inside of destroy_dev().

mav accepted this revision.Apr 10 2021, 4:28 PM

This revision is now accepted and ready to land.Apr 10 2021, 4:28 PM

imp added inline comments.Apr 10 2021, 8:43 PM

sys/dev/iscsi/iscsi.c
2572	This looks fine. But... how do we ensure that all the threads are out of the ioctl handler before we return from here?

mav added inline comments.Apr 11 2021, 1:49 AM

sys/dev/iscsi/iscsi.c
2572	This looks fine. But... how do we ensure that all the threads are out of the ioctl handler before we return from here? destroy_dev() below makes sure of that.

Closed by commit rG89df484739ef: iscsi: Kick threads out of iscsi_ioctl() during unload. (authored by jhb). · Explain WhyApr 12 2021, 8:59 PM

This revision was automatically updated to reflect the committed changes.

jhb added a commit: rG89df484739ef: iscsi: Kick threads out of iscsi_ioctl() during unload..

Revision Contents
Changeset List

Path

Size

sys/

dev/

iscsi/

iscsi.h

1 line

iscsi.c

11 lines

Diff 87347

View Options

sys/dev/iscsi/iscsi.h