Page MenuHomeFreeBSD

qlnxr: Properly initialize the Linux device structure
ClosedPublic

Authored by markj on Apr 5 2021, 8:17 PM.
Tags
None
Referenced Files
F154962638: D29595.id86868.diff
Thu, Apr 30, 8:32 AM
F154923594: D29595.id87306.diff
Thu, Apr 30, 2:12 AM
F154923575: D29595.id87306.diff
Thu, Apr 30, 2:12 AM
Unknown Object (File)
Mon, Apr 27, 12:36 PM
Unknown Object (File)
Fri, Apr 24, 10:21 AM
Unknown Object (File)
Sun, Apr 19, 9:20 PM
Unknown Object (File)
Fri, Apr 3, 2:19 AM
Unknown Object (File)
Fri, Apr 3, 2:19 AM
Subscribers

Details

Summary

types.h defines device_t to be a struct device *, but the definition of
struct device is internal to subr_bus. But, the LinuxKPI also defines a
struct device, so type confusion is possible.

In this case, we were copying a FreeBSD device structure into a Linux
device structure. The Linux device structure is only used for the IB
device, for allocating DMA'able memory. I believe the old version
worked more or less by accident.

Use linux_pci_attach_device() instead, following the example of the
Chelso iwarp driver. Also ensure that we don't leak the faked device
during detach.

Test Plan

None, I do not have any way to test this.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable