Page MenuHomeFreeBSD

qlnxr: Properly initialize the Linux device structure
ClosedPublic

Authored by markj on Apr 5 2021, 8:17 PM.
Tags
None
Referenced Files
F161599976: D29595.id86868.diff
Sun, Jul 5, 6:02 AM
Unknown Object (File)
Sat, Jul 4, 9:21 AM
Unknown Object (File)
Sat, Jul 4, 9:03 AM
Unknown Object (File)
Sat, Jul 4, 2:13 AM
Unknown Object (File)
Thu, Jul 2, 6:43 AM
Unknown Object (File)
Tue, Jun 30, 5:35 PM
Unknown Object (File)
Sun, Jun 28, 11:04 PM
Unknown Object (File)
Tue, Jun 23, 8:47 AM
Subscribers

Details

Summary

types.h defines device_t to be a struct device *, but the definition of
struct device is internal to subr_bus. But, the LinuxKPI also defines a
struct device, so type confusion is possible.

In this case, we were copying a FreeBSD device structure into a Linux
device structure. The Linux device structure is only used for the IB
device, for allocating DMA'able memory. I believe the old version
worked more or less by accident.

Use linux_pci_attach_device() instead, following the example of the
Chelso iwarp driver. Also ensure that we don't leak the faked device
during detach.

Test Plan

None, I do not have any way to test this.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable