Page MenuHomeFreeBSD

qlnxr: Properly initialize the Linux device structure
ClosedPublic

Authored by markj on Apr 5 2021, 8:17 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Oct 8, 2:55 PM
Unknown Object (File)
Sat, Oct 3, 8:20 PM
Unknown Object (File)
Sun, Sep 27, 10:31 AM
Unknown Object (File)
Fri, Sep 25, 11:21 PM
Unknown Object (File)
Sat, Sep 19, 9:49 PM
Unknown Object (File)
Fri, Sep 11, 6:13 AM
Unknown Object (File)
Sep 7 2026, 8:59 PM
Unknown Object (File)
Sep 6 2026, 9:17 AM
Subscribers

Details

Summary

types.h defines device_t to be a struct device *, but the definition of
struct device is internal to subr_bus. But, the LinuxKPI also defines a
struct device, so type confusion is possible.

In this case, we were copying a FreeBSD device structure into a Linux
device structure. The Linux device structure is only used for the IB
device, for allocating DMA'able memory. I believe the old version
worked more or less by accident.

Use linux_pci_attach_device() instead, following the example of the
Chelso iwarp driver. Also ensure that we don't leak the faked device
during detach.

Test Plan

None, I do not have any way to test this.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable