Page MenuHomeFreeBSD
Differential D29381

Drop WARNS for ktrdump(8)
ClosedPublic
Actions

Authored by dchagin on Mon, Mar 22, 6:26 PM.

Details

Reviewers
jhb
imp
Commits
R10:b4dc951c417e: Fix warning about signed comparison and drop WARNS for ktrdump(8).
R10:3802433d25c9: Fix warning about signed comparison and drop WARNS for ktrdump(8).
R10:9e5aeba51b43: Fix warning about signed comparison and drop WARNS for ktrdump(8).

Diff Detail

Repository
R10 FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

dchagin created this revision.Mon, Mar 22, 6:26 PM
Herald added a subscriber: imp. · View Herald TranscriptMon, Mar 22, 6:26 PM
dchagin requested review of this revision.Mon, Mar 22, 6:26 PM
Harbormaster completed remote builds in B37995: Diff 86163.Mon, Mar 22, 6:26 PM
dchagin added a reviewer: jhb.Mon, Mar 22, 6:27 PM
jhb added inline comments.Mon, Mar 22, 7:19 PM
usr.bin/ktrdump/ktrdump.c
59–63

Could we avoid all the 0's if we used this instead:

{ .n_name = "_ktr_version" },

If so, I think I'd prefer that style.

dchagin updated this revision to Diff 86164.Mon, Mar 22, 7:37 PM

Sure, done

Harbormaster completed remote builds in B37996: Diff 86164.Mon, Mar 22, 7:38 PM
jhb accepted this revision.Tue, Mar 23, 7:45 PM
This revision is now accepted and ready to land.Tue, Mar 23, 7:45 PM
imp accepted this revision.Tue, Mar 23, 7:51 PM
Closed by commit R10:9e5aeba51b43: Fix warning about signed comparison and drop WARNS for ktrdump(8). (authored by dchagin). · Explain WhyWed, Mar 24, 7:53 AM
This revision was automatically updated to reflect the committed changes.
dchagin added a commit: R10:9e5aeba51b43: Fix warning about signed comparison and drop WARNS for ktrdump(8)..
dchagin added a commit: R10:3802433d25c9: Fix warning about signed comparison and drop WARNS for ktrdump(8)..Thu, Apr 1, 7:59 AM
dchagin added a commit: R10:b4dc951c417e: Fix warning about signed comparison and drop WARNS for ktrdump(8)..Thu, Apr 1, 8:02 AM

Revision Contents
Changeset List

PathSize
usr.bin/
ktrdump/
2 lines
14 lines

Diff 86240

View Options

usr.bin/ktrdump/Makefile

Loading...
View Options

usr.bin/ktrdump/ktrdump.c

Loading...