Page MenuHomeFreeBSD
Differential D29381

Drop WARNS for ktrdump(8)
ClosedPublic
Actions

Authored by dchagin on Mar 22 2021, 6:26 PM.
Tags
None
Referenced Files
F170446884: D29381.id86163.diff
Fri, Sep 4, 9:11 PM
F170417148: D29381.id.diff
Fri, Sep 4, 5:55 PM
Unknown Object (File)
Fri, Sep 4, 2:41 AM
Unknown Object (File)
Fri, Sep 4, 2:00 AM
Unknown Object (File)
Thu, Sep 3, 5:35 AM
Unknown Object (File)
Wed, Sep 2, 9:52 AM
Unknown Object (File)
Tue, Sep 1, 11:38 PM
Unknown Object (File)
Tue, Sep 1, 11:37 PM
View All Files
Subscribers
imp

Details

Reviewers
jhb
imp
Commits
rGb4dc951c417e: Fix warning about signed comparison and drop WARNS for ktrdump(8).
rG3802433d25c9: Fix warning about signed comparison and drop WARNS for ktrdump(8).
rG9e5aeba51b43: Fix warning about signed comparison and drop WARNS for ktrdump(8).

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

dchagin created this revision.Mar 22 2021, 6:26 PM
Herald added a subscriber: imp. · View Herald TranscriptMar 22 2021, 6:26 PM
dchagin requested review of this revision.Mar 22 2021, 6:26 PM
Harbormaster completed remote builds in B37995: Diff 86163.Mar 22 2021, 6:26 PM
dchagin added a reviewer: jhb.Mar 22 2021, 6:27 PM
jhb added inline comments.Mar 22 2021, 7:19 PM
usr.bin/ktrdump/ktrdump.c
59–63

Could we avoid all the 0's if we used this instead:

{ .n_name = "_ktr_version" },

If so, I think I'd prefer that style.

dchagin updated this revision to Diff 86164.Mar 22 2021, 7:37 PM

Sure, done

Harbormaster completed remote builds in B37996: Diff 86164.Mar 22 2021, 7:38 PM
jhb accepted this revision.Mar 23 2021, 7:45 PM
This revision is now accepted and ready to land.Mar 23 2021, 7:45 PM
imp accepted this revision.Mar 23 2021, 7:51 PM
Closed by commit rG9e5aeba51b43: Fix warning about signed comparison and drop WARNS for ktrdump(8). (authored by dchagin). · Explain WhyMar 24 2021, 7:53 AM
This revision was automatically updated to reflect the committed changes.
dchagin added a commit: rG9e5aeba51b43: Fix warning about signed comparison and drop WARNS for ktrdump(8)..
dchagin added a commit: rG3802433d25c9: Fix warning about signed comparison and drop WARNS for ktrdump(8)..Apr 1 2021, 7:59 AM
dchagin added a commit: rGb4dc951c417e: Fix warning about signed comparison and drop WARNS for ktrdump(8)..Apr 1 2021, 8:02 AM

Revision Contents
Changeset List

PathSize
usr.bin/
ktrdump/
2 lines
14 lines

Diff 86240

View Options

usr.bin/ktrdump/Makefile

Loading...
View Options

usr.bin/ktrdump/ktrdump.c

Loading...