Page MenuHomeFreeBSD

Replace USE_GHOSTSCRIPT with USES=ghostscript
ClosedPublic

Authored by kwm on Jun 29 2015, 9:01 AM.

Details

Summary

First draft of new ghostscript.mk USES. Only included the bare minimum to
not spam this review with all the USE_GHOSTSCRIPT changes. Would like
feedback on the ghostscript.mk content before proceeding with converting
the ports tree, and submitting that for exp-run.

Test Plan

tested with print/libspecter with different arguments.

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

kwm updated this revision to Diff 6534.Jun 29 2015, 9:01 AM
kwm retitled this revision from to Replace USE_GHOSTSCRIPT with USES=ghostscript.
kwm updated this object.
kwm edited the test plan for this revision. (Show Details)
kwm added a reviewer: bapt.
bapt edited edge metadata.Jun 29 2015, 9:14 AM

At first glance it looks good, but that means all the ports using USE_GHOSTSCRIPT should also be converted and a course this will have to go though a couple of exp-runs :)

antoine added inline comments.
Mk/Uses/ghostscript.mk
35 ↗(On Diff #6534)

IIRC bsd.port.mk already does the S/,/ /g

print/libspectre/Makefile
7 ↗(On Diff #6534)

why bump?

kwm updated this revision to Diff 6541.Jun 29 2015, 11:57 AM
kwm edited edge metadata.

Update

Unbump libspecter no revision bump needed.
Add bsd.sanity.mk lines about USE_GHOSTSCRIPT
Add check to check if GHOSTSCRIPT_DEFAULT is a valid value
bsd.port.mk already does _ARGS:S/,/ / so we don't have to.

kwm added a comment.Jun 29 2015, 11:58 AM

And I forgot to include CHANGES, will be back in the next update.

mat added a subscriber: mat.Jun 29 2015, 2:06 PM
mat added inline comments.
Mk/Uses/ghostscript.mk
59 ↗(On Diff #6541)

maybe add the invalid value in the IGNORE message, like ... value: ${GHOSTSCRIPT_DEFAULT}, please ...

kwm updated this revision to Diff 6556.Jun 29 2015, 5:54 PM
kwm marked an inline comment as done.

Small update

Report the actualy incorrect GHOSTSCRIPT_DEFAULT value in the error message
Add CHANGES again.

kwm updated this revision to Diff 6751.Jul 7 2015, 11:01 AM
kwm marked an inline comment as done.

Add antoine@'s suggestion add back WITHOUT_X11 processing.

I tried to write some code to check if OPTIONS_DEFINE=X11 was set and
honoring PORT_OPTIONS:MX11 but I couldn't get that working.

Either we leave it like this or I'm open for suggestions on how to impliment
that.

kwm updated this revision to Diff 7019.Jul 16 2015, 3:05 PM
kwm marked an inline comment as not done.

Drop drupal.mk uses.
Chase ports updates.

This revision was automatically updated to reflect the committed changes.